Onebox doesn't prefer secure_url with HTTPS

Twitch stream embeds are not loaded when linked to from posts on Discourse installs using HTTPS. It seems like og:video:secure_url is not being preferred over og:video by Onebox, but I think it probably should be, at least on secure websites.

Here’s an example:

^ This is https://www.twitch.tv/moonmoon

5 Likes

Sure that makes sense can you fix @techAPJ?

3 Likes

Thanks, guys. I realized that even if Twitch embeds loaded properly, they’d auto-play in posts. Auto-playing videos annoy the hell out of me, so I wrote a Twitch Onebox plugin to fix both problems.

4 Likes

Agreed. Fixed via:

https://github.com/discourse/onebox/commit/d8da08da59e3e65fd1a58060afe5840d8fb42cf9

4 Likes