Tom_Eagle
(Tom Eagle)
March 8, 2021, 8:10pm
1
Hi everyone,
Over on our forum we have a issue where when a URL is oneboxed it changes the actual URL itself.
As a example:
This is a link to our website:
Offspring Probabilities:
1/16 Killer Clown,
3/16 Super Pastel 66% Het Clown,
1/8 Pastel Clown,
3/8 Pastel 66% Het Clown,
1/16 Clown,
3/16 66% Het Clown
But this is what shows when oneboxed:
With:
“%2C” being changed to “,”.
“+” Being changed to “%2B”
Which gives users the wrong results on our site.
Is there a way to stop this happening or a workaround?
Richie
(Richie Rich)
March 8, 2021, 8:19pm
2
Those links are both the same:
https://www.morphmarket.com/c/reptiles/pythons/ball-pythons/genetic-calculator/?s1=Pastel,Het%2BClown&s2=Pastel,Het%2BClown
Can you wrap/backtick them so we can see them as you intended?
1 Like
Tom_Eagle
(Tom Eagle)
March 8, 2021, 8:58pm
3
Sorry, my bad
This is what it should look like:
https://www.morphmarket.com/c/reptiles/pythons/ball-pythons/genetic-calculator/?s1=Pastel%2CHet+Clown&s2=Pastel%2CHet+Clown
This is what happens when oneboxed:
https://www.morphmarket.com/c/reptiles/pythons/ball-pythons/genetic-calculator/?s1=Pastel,Het%2BClown&s2=Pastel,Het%2BClown
If the url is functional in either case, why does it matter?
Tom_Eagle
(Tom Eagle)
March 9, 2021, 11:25am
5
Because they lead to different results.
Here is what should be shown through the link:
Not this:
This makes a huge difference when trying to calculate genetics correctly.
2 Likes
david
(David Taylor)
July 24, 2023, 11:59am
9
It looks like the URLs in the OP are no longer oneboxable (no opengraph tags on the site). But just noting for the record, this issue should have been resolved by
committed 10:55AM - 09 Aug 22 UTC
normalized_encode in addressable has a number of issues, including https://githu… b.com/sporkmonger/addressable/issues/472
To temporaily work around those issues for the majority of cases, we try parsing with `::URI`. If that fails (e.g. due to non-ascii characters) then we will fall back to addressable.
Hopefully we can simplify this back to `Addressable::URI.normalized_encode` in the future.
This commit also adds support for unicode domain names and emoji domain names with escape_uri.
This removes an unneeded hack checking for pre-signed urls, which are now handled by the general case due to starting off valid and only being minimally normalized. Previous test case continues to pass.
UrlHelper.s3_presigned_url? which was somewhat wide was removed.
3 Likes
david
(David Taylor)
Closed
August 23, 2023, 12:00pm
10
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.