Open external links in new tab not working when link is within a quote block

Bug
1

I’ve noticed for a while that links are not opening in new tabs. I thought it was my imagination. I’ve finally managed to replicate it.

I most recently noticed it here: Set up Zulip notifications using the chat integration plugin

And this quoted link opens in the same tab rather than a new one. I thought it might be some browser plugin, but I get the same behavior in an incognito window.


[quote]
:warning: This integration will not be functional until the [Discourse integration is added to Zulip's codebase](https://github.com/zulip/zulip/pull/6201)
[/quote]
6 Likes
2

Can we repro this @jomaxro?

3

The Github link in the quote above is certainly not opening in a new tab for me. I’ll do more thorough testing tomorrow.

3 Likes
6

@sam I can repro this - the quote block appears to be causing the issue. Links work fine when on their own, whether pasted as a raw line, or in the [some text](a link) format. However, when placed inside a `[quote][/quote] all external links fail to open in a new tab.

5 Likes
7

I don’t know if it’s related or not, but I notice the link inside the above quote isn’t getting the link tracker count indicator.

5 Likes
9

Here it doesn’t work in a solved inset (in OT):

https://meta.discourse.org/t/configuring-instagram-login-for-discourse/51642?u=pfaffman

1 Like
11

Wow I think this bug existed pretty much ever since we launched Discourse.

Fixed per:

https://github.com/discourse/discourse/commit/2423b18839481c9dabf7b34b18146f79b68e3abf

5 Likes
12

This topic was automatically closed after 28 hours. New replies are no longer allowed.