Option to move accepted answer to the top

[sam (Sam Saffron)]

I reviewed and merged, I feel it looks a bit naked though without the excerpt would love to see that in as well.

[david (David Taylor)]

I agree having an excerpt would be nicer, I did get it working by adding to the serialiser:

@david

Screenshot

Then you can click the header, and it expands to the full post:

Screenshot

Edit: wow, quoting [details] went badly

And the code here.

However…

@david

Currently, if you go and change the “solution” then it causes the page to jump around all over the place because the height of the first post is changing. This happens with the discourse-solved plugin right now, but it’s not really noticeable since it’s only 1 line of text. I’m not really sure of a solution for this… Either we don’t update it live (so you have to reload the topic to see the quote), or have some kind of placeholder when the topic isn’t solved.

[sam (Sam Saffron)]

I think if the excerpt is short enough the jumping should be very very limited, under almost all cases. In the vast majority of cases people edit to add more content, not to remove, so the excerpt would be unchanged.

One big issue though is that it has an “up” arrow which is very confusing UX wise, so that would have to go.

[david (David Taylor)]

@sam

In the vast majority of cases people edit to add more content, not to remove, so the excerpt would be unchanged.

The issue is not so much when people edit their solutions - it’s when the solution is changed by the OP or a moderator.

@sam

One big issue though is that it has an “up” arrow which is very confusing UX wise, so that would have to go.

Yep, definitely.

How long do you think the excerpt should be? I had it hardcoded at 100 characters, but that’s a bit arbitrary. Shall I add a setting for it? Or do you think that is configuration for configuration’s sake?

[sam (Sam Saffron)]

I actually think it should be configurable, 100 is a good default.

I don’t know it should be fairly rare to be mucking with accepted answer, and unaccepting causes a jump anyway. I think we can live with it.

[david (David Taylor)]

Here we go - configurable length quote, click to expand to full post, and only shows the down arrow.

https://github.com/discourse/discourse-solved/pull/50

Having just tried it with a topic with many posts, it doesn’t actually affect the scrolling as much as I thought

[sam (Sam Saffron)]

I am quite happy with the styling now! thanks @david