Order is not respected on back button when admin user list is re-ordered

UX
1

This is a minor ux bug:

  1. Visit admin/users
  2. re-order list by topics viewed
  3. Click badges
  4. Click back

image

Second minor bug

  1. Visit admin/users
  2. re-order list by topics viewed
  3. Click badges
  4. Click “users”

Same reordering bug shows up, topics viewed is incorrectly selected.

5 Likes
2

Hi,
I was able to find out where the issue is. When we load users we fetch users using this:
https://github.com/discourse/discourse/blob/master/app/assets/javascripts/admin/routes/admin-users-list-show.js.es6#L6

Here, we don’t pass the parameter of order(topic_viewed etc) and ascending to findAll function.

But on the first load(refresh), this function gets called by callback:
https://github.com/discourse/discourse/blob/1381dc603d4dcad3c2ac6e12488692241fcbc79d/app/assets/javascripts/admin/controllers/admin-users-list-show.js.es6#L51
which again fetches users with order and ascending values.

When we go to badges and come back, this function doesn’t get called by any callback. Can anyone explain to me why?
I don’t want to change the first file to pass ascending and order from params to findAll since it will affect others using that class.

I m new to Ember :bowing_man: Is there any other better way to solve this issue?

Thanks

2 Likes