Photography Domain Invalid as Website on Profile

Splitterside · December 20, 2017, 5:24pm

Hi,

I help run a large photography community and several of our members are trying to use the .photography domain for their website list in their profile, but receive a message saying the website is invalid. The format that is being attempted looks like this.

http://www.example.photography

But this is the error message that is received.

I’ve looked for a setting or something that would allow this type of domain, but I couldn’t find anything. How could support be added for the .photography domain?

Thanks,
-Adam

sam · December 18, 2017, 7:50pm

@tgxworld is this a spot where your mini suffix gem is missing?

Splitterside · December 19, 2017, 3:14pm

Hi @sam, thanks for the response. I am guessing by your reply @tgxworld is the person that knows the answer to my question, correct? Thanks for the help you all can provide.

codinghorror · December 20, 2017, 6:55am

If the risk is low and the code already exists to do this, we should get it in for 1.9.

tgxworld · December 20, 2017, 7:01am

What do you have configured for user website domains whitelist in your site settings? That validation you ran into is only activate if user website domains whitelist is configured.

Splitterside · December 20, 2017, 2:07pm

There is nothing in that field. See below:

tgxworld · December 20, 2017, 2:19pm

Can you run the following commands for me just to confirm

./launcher enter app
bundle exec rails console
> SiteSetting.user_website_domains_whitelist

RGJ · December 20, 2017, 3:16pm

It’s empty.

Please note that this instance is on 1.8.10 stable (hosted with us)

@Splitterside if it turns out that the version has something to do with it, we can upgrade you to 1.9 latest beta if you want to.

tgxworld · December 20, 2017, 3:28pm

Hmm this is abit of a mystery to me…

The only place that code is called

github.com

discourse/discourse/blob/v1.8.10/app/models/user_profile.rb#L107-L113


def website_domain_validator
  allowed_domains = SiteSetting.user_website_domains_whitelist
  return if (allowed_domains.blank? || self.website.blank?)


  domain = URI.parse(self.website).host
  self.errors.add :base, (I18n.t('user.website.domain_not_allowed', domains: allowed_domains.split('|').join(", "))) unless allowed_domains.split('|').include?(domain)
end

Falco · December 20, 2017, 3:30pm

I believe they need this commit:

So, the fix is live on the 1.9.x branch (as always).

tgxworld · December 20, 2017, 3:31pm

Ah thank you!! I totally missed

github.com

discourse/discourse/blob/master/app/models/user_profile.rb#L10


# frozen_string_literal: true


class UserProfile < ActiveRecord::Base
  belongs_to :user, inverse_of: :user_profile
  belongs_to :card_background_upload, class_name: "Upload"
  belongs_to :profile_background_upload, class_name: "Upload"
  belongs_to :granted_title_badge, class_name: "Badge"
  belongs_to :featured_topic, class_name: 'Topic'


  validates :bio_raw, length: { maximum: 3000 }
  validates :website, url: true, allow_blank: true, if: Proc.new { |c| c.new_record? || c.website_changed? }
  validates :user, presence: true
  before_save :cook
  after_save :trigger_badges


  validate :website_domain_validator, if: Proc.new { |c| c.new_record? || c.website_changed? }


  has_many :user_profile_views, dependent: :destroy


  BAKED_VERSION = 1

Splitterside · December 20, 2017, 3:35pm

Thanks everyone for the clarity.

I get that it’s in beta, so there will always be bugs, but are there any major concerns about upgrading to 1.9? Is there an ETA for the release of 1.9?

Falco · December 20, 2017, 3:41pm

It’s coming this year, so it’s very soon!

@tgxworld should we move this validation to your new gem ? Sounds like a good idea.

tgxworld · December 20, 2017, 3:42pm

Yea should be pretty low risk so I’ll give it a crack tml.

Splitterside · December 20, 2017, 4:11pm

Thanks @Falco for the quick answer.

@RGJ I am not sure that we want to update to the beta until it is released since it sounds like it is around the corner. Would it be possible to mark our account to be updated once it is released? Thanks.

RGJ · December 20, 2017, 4:34pm

We were going to do that anyway

tgxworld · December 21, 2017, 6:24am

OK so I had a look through the previous commits and realized that what we initially wanted to do is to validate the format of the URL. That means that there is no need for us to care about whether the URL would return a valid HTTP response as that would require a different solution if we wanted to verify that.

However, I did noticed that our UrlValidator wasn’t handling a bunch of cases properly and that has been fixed in

https://github.com/discourse/discourse/commit/6ecf37c482603cba27510e41723fdd1909d0a135

I’ve also switched the validation for UserProfile#website to use our UrlValidator which removes the Regexp that has been quite problematic for us

tgxworld · December 21, 2017, 6:27am

Do we also want to treat non-ascii URLs, like http://見.香港/, as valid?

sam · December 21, 2017, 6:45am

I guess we should, it seems to work in the browser.

system · February 27, 2020, 3:01pm