Possible copy&paste mistake in Discourse User Model Code

Moin · August 1, 2024, 10:39am

I have the impression that silencedTill in line 401 and 402 should be suspendedTill

discourse/discourse/blob/608e5682e2e706fec20fbe4b82b8b95cb962072d/app/assets/javascripts/discourse/app/models/user.js#L390-L408


      
          @discourseComputed("suspended_till")
          suspendedForever(suspendedTill) {
            return isForever(suspendedTill);
          }
          
          @discourseComputed("silenced_till")
          silencedForever(silencedTill) {
            isForever(silencedTill);
          }
          
          @discourseComputed("suspended_till")
          suspendedTillDate(silencedTill) {
            return longDate(silencedTill);
          }
          
          @discourseComputed("silenced_till")
          silencedTillDate(silencedTill) {
            return longDate(silencedTill);
          }

joffreyjaffeux · August 1, 2024, 1:33pm

Yes you are correct, however this is not impacting behavior, just the name is incorrect.

That will do it:

Firepup650 · August 1, 2024, 1:35pm

Shouldn’t line 397 be a return statement as well?

joffreyjaffeux · August 1, 2024, 1:50pm

Yes it should indeed, that’s a behavior change, a mistake we did in a refactoring few months ago.

Topic		Replies	Views
Bug with Discourse chat silencing Bug chat	9	409	December 1, 2022
Clearer display of "forever" suspensions/silencing Support	9	922	September 2, 2020
API not returning suspended fields properly Bug	6	1051	October 13, 2017
Suspend API Not Working Dev rest-api	13	1199	January 7, 2021
How to unsilence a user who innocently tried to copy & paste and got silenced Support	4	703	January 10, 2019

Possible copy&paste mistake in Discourse User Model Code

Related topics