Previously selected user themes can override allowed themes

(Jay Pfaffman) #1

On Discourse 1.9.2 (stable) if there exists a theme “A” that gets saved as a user’s default theme and then you create a theme “B” and make theme “A” not selectable by users, people who have selected theme A still get theme A.

And if theme B is the only available theme, then there is no selector on /my/preferences/interface to be able to select theme B.

(Vaping Community) #2

Even if you make theme B the default?

Can I assume that the theme choice is saved inside the session?
I’ve been messing with my themes all day and have noticed that sometimes if I disable a theme I still have it until I clear the browser cache.

(Jay Pfaffman) #3

Yes. Theme B is the default and no other themes are user-selectable. You have to change the theme in the user profile to get to it (or perhaps clear the browser cache?).

(Vaping Community) #4

I cleared the browser cache and it reset to the default for me, I’m running v2 though…

(Jay Pfaffman) #5

Thanks. I suggested that to my not-so-technically-adept client who is more adept than most of their community.

(Vaping Community) #6

Hopefully that fixes the problem, I guess the other way is to go through admin and change it manually for them (headache)

(Jay Pfaffman) #7

It’s possible to update them all from the Rails console.

(Vaping Community) #8

Oh, nice, I’m still learning the basic commands, is there a cheat sheet for discourse commands?

(Jay Pfaffman) #9

Not quite what you’re looking for. In Completely disable mailing list mode? I found this

./launcher enter app
rails c
UserOption.update_all(mailing_list_mode: false)

You’d do something similar, like

UserOption.update_all(theme_key: 666)

Which I found by looking in discourse/app/models/user_option.rb.

(Vaping Community) #10

So you force the same theme_key on every user, I assume that is the theme ID?

(Jay Pfaffman) #11

That’s what it looks like. That’s not tested. It might kill your dog or something.

(Vaping Community) #12

Ok, I just ran a test and clearing the browser cache DOES change the theme to the default one in v2 if the one the user was previously using has been removed and a new one has been set as default.

If Make this my default theme on all devices is checked it should revert on the next refresh.

(Sam Saffron) #14

This is only the case if you are an administrator, as an end user this can not happen. I just confirmed cause we do a security check and only allow end users to see themes that are user selectable.

I am recategorizing this as support for now cause I feel it is too minor to need fixing.