Quote Callouts

Great, it worked fine! Thank you for the quick fix :slightly_smiling_face:

Have a great day!

2 Likes

This is really a great component, but it currently still displays as a citation style in the revision history view. Can this scenario be supported? :smiley:
image

3 Likes

It also appears like that in excerpts too, and in Oneboxes.

I suspect that it might be tricky to cover all the edge cases though.

4 Likes

Hi! I noticed a potential usability issue with the default Ctrl + Q shortcut on macOS.

Many Mac users instinctively press ⌘ + Q instead of Ctrl + Q, since ⌘ is the primary modifier key used for most shortcuts on macOS. Unfortunately, ⌘ + Q is also the system-wide shortcut for quitting the application/browser.

As a result, users may accidentally quit their browser while trying to insert a callout.

It’s not impossible, I gave it a try yesterday. I will see what I can do!

It should be hidden in excerpt unless something is broken again, but yes not hidden in onebox yet. I will keep in mind, thanks!

Good catch :scream:
Any suggestions? I’m thinking of using ctrl/⌘ + alt + c instead. That sounds safe, I hope.

5 Likes

I pushed an update.

  • Callouts are now rendered in history revision. Thanks for the suggestion @Noble_Fish. It might need ajustements, like not rendered in some situations. The collapse toggle is ignored and not rendered. Let me know how it plays on your side!
  • Onebox excerpt should strip the callout marker. Works in RTE too. Let me know if you see other cases @nathank.
  • Shortcut changed to ctrl/⌘ + alt + c. Great catch @scavin. It should be a safe change.
7 Likes

Just a style issue: I’ve noticed that the code styling within quote callouts titles appears much shorter in length compared to normal text, which can cause it to be completely obscured by symbols like β–ˆ , and in languages such as Chinese, some larger text sizes may cause the four corners of its bounding box to go out of bounds, making it look odd.

1 Like

I pushed a fix. It adds missing core CSS to <code> HTML in the callout title. Also, it removes extra newline spaces. Overall, this should be consistent now!

4 Likes