Quotes pointing to deleted post gets stuck loading

貢献 特徴
1

Go to the following post:

Try load the full quote and you’ll get the Loading... text and it’ll stay there. You can’t toggle it back either; it’s stuck in that operation.

「いいね！」 2
2

This is more or less by design.. the only improvement would be for “loading…” to say “post was deleted” instead. So it’s a feature req.

「いいね！」 1
3

Well, clicking the toggle also gets you into an unrecoverable state (without refresh) where you can’t toggle back to the on-page quote. That’s a minor bug imo.

As for how to keep users from encountering it, I suppose the simplest fix of all would be to not display the toggle-arrow if the topic no longer exists.

4

Can’t know that until we check on click.

5

Okay, but the code can tell when the request failed, and go back to the original state. We could fix that.

「いいね！」 4
6

This “issue” is still here on Meta (example in the OP of this topic https://meta.discourse.org/t/cross-origin-framing/26984) exactly as described by @erlend_sh

I think that new user can be really in difficult to understand what’s happening, the only way to see what is wrong is open the browser console and look at the error Not Found.

Change Loading... with This post was deleted, as @codinghorror said above, is a good compromise to me.

「いいね！」 4
7

Sure can you make that change @eviltrout? This one is long overdue.

「いいね！」 3
9

I think this was done? If I try as anonymous I get a trash icon instead.

Screen Shot 2017-04-24 at 1.39.15 PM.png1278×176 7.37 KB

「いいね！」 3
10

Good ol’ @neil did it!

「いいね！」 3
13

どうやらここで一種の回帰が発生しているようです。Dean からの埋め込みリンク Manually update Discourse and Docker image to latest - #112 をご覧ください。そこでは無限の「読み込み」が表示されています。リンクを含む単純な引用ではまだ機能していますが、削除されたトピックや投稿へのリンクでは機能しません。

Uc4wgdh
Uc4wgdh793×343 17.2 KB

編集: このトピックの元の投稿を見ると、引用内にリンクがある場合は機能しないようです。「読み込み」が1秒未満表示されますが、参照リンクやテキストが削除されたことを示す「ゴミ箱」アイコンは表示されません。この場合、通常のユーザーは引用内のリンクをクリックして404ページに到達してしまいます。

つまり、リンクを含まない非常に単純なテキストの引用では機能します。

「いいね！」 2
14

Is this fixable easily @eviltrout? Maybe take a peek Monday.

「いいね！」 1
15

Looks like the bug was where the post was in a deleted topic (but the post was not deleted) it would return InvalidAccess instead of a 404. This fixes it and shows the trash can again.

https://github.com/discourse/discourse/commit/89a1b34480e89e8dc1d47c749f08ed1225a173e4

「いいね！」 3