Go to the following post:
Try load the full quote and you’ll get the Loading... text and it’ll stay there. You can’t toggle it back either; it’s stuck in that operation.
2 curtidas
This is more or less by design.. the only improvement would be for “loading…” to say “post was deleted” instead. So it’s a feature req.
1 curtida
Well, clicking the toggle also gets you into an unrecoverable state (without refresh) where you can’t toggle back to the on-page quote. That’s a minor bug imo.
As for how to keep users from encountering it, I suppose the simplest fix of all would be to not display the toggle-arrow if the topic no longer exists.
Can’t know that until we check on click.
Okay, but the code can tell when the request failed, and go back to the original state. We could fix that.
4 curtidas
This “issue” is still here on Meta (example in the OP of this topic https://meta.discourse.org/t/cross-origin-framing/26984) exactly as described by @erlend_sh
I think that new user can be really in difficult to understand what’s happening, the only way to see what is wrong is open the browser console and look at the error Not Found.
Change Loading... with This post was deleted, as @codinghorror said above, is a good compromise to me.
4 curtidas
Sure can you make that change @eviltrout? This one is long overdue.
3 curtidas
Good ol’ @neil did it!
3 curtidas
Parece que temos uma espécie de regressão aqui. Dê uma olhada no link embutido Manually update Discourse and Docker image to latest - #112, de Dean: lá é exibido um “carregando” infinito. Ainda funciona em citações simples que contêm um link, mas não para tópicos ou posts vinculados que foram excluídos.
EDIT: Ao analisar a postagem original deste tópico, parece que não funciona com um link dentro de uma citação. Exibe “carregando” por menos de 1 segundo, mas não mostra o ícone de “lixeira” que indica que o link ou texto de referência foi excluído. Nesse caso, um usuário comum tende a clicar no link da citação e acaba na página 404.
Portanto, funciona apenas com citações de texto muito simples, sem links no interior.
2 curtidas
Is this fixable easily @eviltrout? Maybe take a peek Monday.
1 curtida
Looks like the bug was where the post was in a deleted topic (but the post was not deleted) it would return InvalidAccess instead of a 404. This fixes it and shows the trash can again.
https://github.com/discourse/discourse/commit/89a1b34480e89e8dc1d47c749f08ed1225a173e4
3 curtidas