`rake uploads:migrate_to_s3` needs some love

The uploads:migrate_to_s3 rake task could use some attention.

There is no GlobalSetting.use_s3?, but a GlobalSetting.use_s3 and the ENV variables have changed, as DISCOURSE_S3_BUCKET has been replaced by DISCOURSE_S3_UPLOAD_BUCKET.

I’m only a little bit sure that I know how to fix this, and I think that it’s fresh in @gerhard’s mind. :slight_smile:

1 Like
[1] pry(main)> GlobalSetting.use_s3
NoMethodError: undefined method `use_s3' for GlobalSetting:Class
Did you mean?  use_s3?

The code in the rake task is still valid from what I can tell. Did you run into any specific problems that made you bring up the issues above?

2 Likes

uh. Hmm. I’ll try again.

I think I’m confused because it seems like it should be able to read those variables from SiteSettings and I don’t understand how the backup and upload buckets get defined from just the S3 bucket.

For GlobalSettings,

Only SiteSettings that are marked shadowed_by_global can be configured via the env. In this case, s3_upload_bucket isn’t.

Closing this as this isn’t a bug.

5 Likes