`rake uploads:migrate_to_s3` needs some love

tgxworld · February 19, 2019, 12:17am

For GlobalSettings,

discourse/discourse/blob/4f5aebc33812a56c34e553bd18c0cfe7ddc4c3f4/config/discourse_defaults.conf#L7-L13


      
          # Discourse supports multiple mechanisms for production config.
          #
          # 1. You can do nothing and get these defaults (not recommended, you should at least set hostname)
          # 2. You can copy this file to config/discourse.conf and amend with your settings
          # 3. You can pass in config from your environment, all the settings below are available.
          #    Append DISCOURSE_ and upper case the setting in ENV. For example:
          #    to pass in db_timeout of 200 you would use DISCOURSE_DB_TIMEOUT=200

Only SiteSettings that are marked shadowed_by_global can be configured via the env. In this case, s3_upload_bucket isn’t.

github.com

discourse/discourse/blob/4f5aebc33812a56c34e553bd18c0cfe7ddc4c3f4/app/models/site_setting.rb#L129-L131


      
          def self.s3_upload_bucket
            SiteSetting.enable_s3_uploads ? SiteSetting.s3_upload_bucket : GlobalSetting.s3_bucket
          end

Closing this as this isn’t a bug.

Topic		Replies	Views
Migrate_from_s3: You must disable S3 uploads before running that task Support	21	1273	September 19, 2020
GlobalSetting.use_s3? - false Installation s3	3	599	June 10, 2020
S3 configuration expectations between global and site settings Dev	0	828	June 4, 2020
Uploads migration to S3 fails Support	26	2949	May 7, 2021
Migrate_to_s3 for Digital Ocean Spaces woes Installation s3	26	3098	April 27, 2019

`rake uploads:migrate_to_s3` needs some love

Related topics