"rebake old posts count" option is a bit confusing

Alex_P · February 18, 2021, 6:02pm

There is rebake old posts count option in admin settings with this description:

Number of old posts to be rebaked every 15 minutes

At first I thought that Discourse always rebakes some old posts, but after looking at the baked_at field of old posts I noticed that it does not happen.

So I looked into the source code, and it seems like this option is used only for rebakes after some major updates/fixes in Discourse (and so far there was only one such case in 2017).

github.com

discourse/discourse/blob/4739bdac0a9d23d175a4eb61ddf008f25c83cf9b/app/models/post.rb#L630


      
          
          limiter = RateLimiter.new(
            nil,
            "global_periodical_rebake_limit",
            GlobalSetting.max_old_rebakes_per_15_minutes,
            900,
            global: true
          )
          
          problems = []
          Post.where('baked_version IS NULL OR baked_version < ?', BAKED_VERSION)
            .order('id desc')
            .limit(limit).pluck(:id).each do |id|
            begin
          
              break if !limiter.can_perform?
          
              post = Post.find(id)
              post.rebake!(priority: priority)
          
              begin

github.com

discourse/discourse/blob/4739bdac0a9d23d175a4eb61ddf008f25c83cf9b/app/models/post.rb#L24


      
            "avg_time", # TODO(2021-01-04): remove
            "image_url" # TODO(2021-06-01): remove
          ]
          
          cattr_accessor :plugin_permitted_create_params
          self.plugin_permitted_create_params = {}
          
          # increase this number to force a system wide post rebake
          # Recreate `index_for_rebake_old` when the number is increased
          # Version 1, was the initial version
          # Version 2 15-12-2017, introduces CommonMark and a huge number of onebox fixes
          BAKED_VERSION = 2
          
          rate_limit
          rate_limit :limit_posts_per_day
          
          belongs_to :user
          belongs_to :topic
          
          belongs_to :reply_to_user, class_name: "User"

Maybe the description should be improved.

codinghorror · February 18, 2021, 8:47pm

Hmm, maybe, what do you think @sam? Wouldn’t hurt to have a bit more info in this setting description?

sam · February 23, 2021, 5:28am

Sure happy to update the description.

How does this sound @codinghorror

Maximum number of posts to be automatically rebaked after major changes to the Discourse rendering engine every 15 minutes.

Maximum number of old-version posts to be re-rendered to HTML every 15 minutes. Will only impact major rendering engine upgrades. (once every few years)

Hard to know what fidelity the description here needs?

codinghorror · February 23, 2021, 5:58am

Can we perhaps hide this setting altogether? It seems sooo rare that anyone would need to mess with it at all, and it’s so very specialized. A setting you only (maybe?) need to adjust every few years

I vote we pull this setting out and be done?

sam · February 23, 2021, 7:06am

OK done per:

https://github.com/discourse/discourse/pull/12181

Setting is now default hidden. I agree the text there was very confusing, thanks for bringing it up Alex!

sam · February 23, 2021, 9:00pm

This topic was automatically closed after 13 hours. New replies are no longer allowed.

Topic		Replies	Views
Rebake all posts? Installation	16	8648	October 28, 2022
Rebaking for automatic header anchors? Support	1	775	April 8, 2021
What rebake is required for the new autocomplete styling? Support hashtag-autocomplete	20	1431	March 12, 2023
Odd behaviour of the "New Topics" count? Support	8	826	June 8, 2024
Discourse and CommonMark Feature	18	4573	February 9, 2017

"rebake old posts count" option is a bit confusing

Related Topics