Regarding theme-color

Hello, I am new here.

First and foremost I would like to say that discourse is an awesome piece of software.

Anyway, my problem was, I have created my own color scheme through Customize > Colors tab. With the header_background set to BE1E2D.

Everything is working fine visually except the meta still generate white color like the following <meta name="theme-color" content="#ffffff">. Because of this, the address bar in chrome for android is showing in white color.

Based on my research from https://github.com/discourse/discourse/blob/master/app/views/layouts/_head.html.erb the theme-color should change according to ColorScheme header-background.

Also, from https://github.com/discourse/discourse/blob/master/app/controllers/metadata_controller.rb , we can also see that the theme_color should also generate from header-background but it is also showing #ffffff in manifest.json.

5 Likes

Good catch, yeah we should probably take that color from the active color scheme.

3 Likes

Looks like @neil fixed this here :heart_exclamation:

https://github.com/discourse/discourse/commit/389a0e

7 Likes