Regression: quoting text from a closed topic

Continuing the discussion from Quote post from closed topic:

I think this used to be fixed but has regressed now:

I encountered this in the wild as a normal user on elastic trying to do normal user things.

(attn: @eviltrout)

5 Likes

@supermathie I asked in chat but I think it got lost: was this the result of you disabling a user preference for highlight quoting?

3 Likes

It was not. Quoting was enabled and worked on open topics on both sites.

1 Like

Can we repro this @jomaxro? Does feel like a bug and a regression to me?

3 Likes

I can repro, yes. Quote button isn’t appearing for non-staff users in closed topics. Old discussion for reference: Quote post from closed topic

4 Likes

Can we get this fixed and backported @eviltrout?

4 Likes

Sent in FIX: Allow quoting from a closed topic while writing a reply by riking · Pull Request #9121 · discourse/discourse · GitHub !

4 Likes

Noticed another quoting regression. The quote button does not appear within [quote] blocks. It does work in quote blocks that include a username, like [quote=jomaxro], as well as in > blocks.

Works:

[quote=jomaxro]
Lorem Ipsum
[/quote]
> Lorem Ipsum

Doesn’t work:

[quote]
Lorem Ipsum
[/quote]

Let me know if you’d rather have this split into a dedicated topic.

1 Like

Sorry, what are you reporting here? I am unclear.

1 Like

I think he meant that the quote button does not pop up if you post [quote] blocks manually without a username. Try quoting this:

The Quote button does not show up:

image


On the other hand, it shows up as expected when username is added. Try quoting this:

You’ll see that the quote button shows up:

image


This should only affect users that type in quote blocks manually.

6 Likes

This is probably causing a false positive on the nested-quote-quoting-misattribution protection.

5 Likes

Or, it’s just straight-up throwing a Javascript exception :slight_smile:

8 Likes