Quote button on closed topics still does not behave as expected

(Richard - DiscourseHosting.com) #1

Continuing the discussion from Quote post from closed topic:

I was trying to reply using selecting text and pressing the quote button, but the selected text was not appearing in the editor. Turns out the topic was closed and I was creating a new topic.

I found a few other threads about this and they all suggest that everything is working as expected now, but I am still puzzled why I get a quote button that does not actually quote the selected text…

Quotes that start new topic do not work
(Jeff Atwood) #2

What should the behavior be, exactly? We don’t want to encourage people to create a bunch of new topics just by quoting.

(Richard - DiscourseHosting.com) #3

If there is a quote button, it should… quote?

So if that is not desired, there shouldn’t be a quote button, just a “reply as new topic” button somewhere.
Or it should quote but discourage people in some other way to create a new topic.

(Jeff Atwood) #4

It will quote, if you have a valid editor up. The question is, should a new editor be triggered in this case?

Try it yourself

  1. Start a new topic or a new reply to an existing topic
  2. Navigate to a closed topic and begin quoting

(Richard - DiscourseHosting.com) #5

That also works if you quote on the same closed topic twice.

I’ve always been taught Albert Einsteins wise quote “Insanity: doing the same thing over and over again and expecting different results” but now that actually is the case :slight_smile:

The first time it only opens up an editor, the second time it has an editor and it quotes the text.

But ok: if there is logic that prevents the quote button from quoting, why not apply the same logic to prevent the quote button from appearing ? Because now there is a quote button that sometimes does… nothing. And the next time it does work…

(Jeff Atwood) #6

Interesting, maybe this is more of a straight up bug? Can you check @techapj?

(Erlend Sogge Heggen) #7

So how do we want this to work? Do we want the quote button to show up only if you have the editor open?

(Richard - DiscourseHosting.com) #8

Two things:

  1. If a quote button is shown and used, it should always work.
  2. Don’t show the quote button at all if (the topic is closed and there is no editor already open).

(Joshua Rosenfeld) #9

I personally prefer option 1. That being said, option 2 is much better than the current system.

(Richard - DiscourseHosting.com) #10

Those weren’t options, it were two rules that both need to be satisfied.

(Joshua Rosenfeld) #11

I’m confused why they both need to be satisfied. At the moment, the quote button is always shown. As such, the condition in rule 1 is true, so the consequence (it should always work) would be true as well. In this case, rule 2 never applies as the quote button is always shown.

Am I not understanding something?

(Richard - DiscourseHosting.com) #12

The quote button is not quoting if pressed in a closed topic by design:

Because of this requirement, the current behavior is that pressing the quote button in a closed topic doesn’t quote, except when there is an editor open. However, it does open an editor, but without quoting. That’s confusing.

Pressing the quote button twice does what the user expect since the second time, an editor is already open.

So that’s bad, IMHO.

  • the quote button appears but does not quote
  • pressing the quote button twice circumvents preventing the functionality that discourages opening a new topic. Yes, having to press a button twice will actually discourage it’s use, but it also confuses the user.

(Joshua Rosenfeld) #13

Agreed. I understand that the current lack of quoting on first click is by design. However, I still don’t understand why rule 2 is needed if rule one applied. If the quote button is always displayed, it should always work, and work consistently. In that case, there would never be “don’t show the quote button”.

(Richard - DiscourseHosting.com) #14

Because @codinghorror doesn’t want it to work that way, and I can see why: it would it make too easy to (accidentally) create a new topic by quoting something from a closed topic.

(Jeff Atwood) #15

Yes, this is a serious negative. Starting a new topic should be very intentional.