Reply_id ?! did something got mess up?

noticed this new error start popping up after upgrade to the latest.

and there is no such field

Guess something is a half baked or mis-typed

Dashboard reports that sidekiq ins’t happy with this.

2 Likes

The reply_id column has been renamed to reply_post_id. Could you please post the complete stacktrace of that error?

2 Likes

yeah, found a recent commit log around that in tests-passed. Here is the trace.

/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/rack-mini-profiler-1.1.4/lib/patches/db/pg.rb:69:in `async_exec_params'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/rack-mini-profiler-1.1.4/lib/patches/db/pg.rb:69:in `exec_params'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/postgresql_adapter.rb:672:in `block (2 levels) in exec_no_cache'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-6.0.1/lib/active_support/dependencies/interlock.rb:48:in `block in permit_concurrent_loads'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-6.0.1/lib/active_support/concurrency/share_lock.rb:187:in `yield_shares'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-6.0.1/lib/active_support/dependencies/interlock.rb:47:in `permit_concurrent_loads'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/postgresql_adapter.rb:671:in `block in exec_no_cache'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/abstract_adapter.rb:718:in `block (2 levels) in log'
/home/discourse/.rvm/rubies/ruby-2.6.1/lib/ruby/2.6.0/monitor.rb:230:in `mon_synchronize'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/abstract_adapter.rb:717:in `block in log'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-6.0.1/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/abstract_adapter.rb:708:in `log'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/postgresql_adapter.rb:670:in `exec_no_cache'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/postgresql_adapter.rb:651:in `execute_and_clear'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in `exec_query'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/abstract/database_statements.rb:487:in `select'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/abstract/database_statements.rb:70:in `select_all'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/abstract/query_cache.rb:105:in `block in select_all'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/abstract/query_cache.rb:123:in `block in cache_sql'
/home/discourse/.rvm/rubies/ruby-2.6.1/lib/ruby/2.6.0/monitor.rb:230:in `mon_synchronize'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/abstract/query_cache.rb:114:in `cache_sql'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/connection_adapters/abstract/query_cache.rb:105:in `select_all'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/querying.rb:46:in `find_by_sql'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/relation.rb:810:in `block in exec_queries'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/relation.rb:828:in `skip_query_cache_if_necessary'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/relation.rb:797:in `exec_queries'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/relation.rb:615:in `load'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/relation.rb:250:in `records'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.1/lib/active_record/relation/delegation.rb:85:in `each'
/home/discourse/prod/discourse/lib/email/sender.rb:120:in `map'
/home/discourse/prod/discourse/lib/email/sender.rb:120:in `send'
/home/discourse/prod/discourse/app/jobs/regular/user_email.rb:60:in `execute'
/home/discourse/prod/discourse/app/jobs/base.rb:232:in `block (2 levels) in perform'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/rails_multisite-2.0.7/lib/rails_multisite/connection_management.rb:63:in `with_connection'
/home/discourse/prod/discourse/app/jobs/base.rb:221:in `block in perform'
/home/discourse/prod/discourse/app/jobs/base.rb:217:in `each'
/home/discourse/prod/discourse/app/jobs/base.rb:217:in `perform'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:196:in `execute_job'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:164:in `block (2 levels) in process'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/middleware/chain.rb:138:in `block in invoke'
/home/discourse/prod/discourse/lib/sidekiq/pausable.rb:138:in `call'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/middleware/chain.rb:140:in `block in invoke'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/middleware/chain.rb:143:in `invoke'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:163:in `block in process'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:136:in `block (6 levels) in dispatch'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/job_retry.rb:111:in `local'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:135:in `block (5 levels) in dispatch'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/rails.rb:43:in `block in call'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-6.0.1/lib/active_support/execution_wrapper.rb:88:in `wrap'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-6.0.1/lib/active_support/reloader.rb:72:in `block in wrap'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-6.0.1/lib/active_support/execution_wrapper.rb:88:in `wrap'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-6.0.1/lib/active_support/reloader.rb:71:in `wrap'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/rails.rb:42:in `call'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:131:in `block (4 levels) in dispatch'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:257:in `stats'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:126:in `block (3 levels) in dispatch'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/job_logger.rb:13:in `call'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:125:in `block (2 levels) in dispatch'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/job_retry.rb:78:in `global'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:124:in `block in dispatch'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/logger.rb:10:in `with'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/job_logger.rb:33:in `prepare'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:123:in `dispatch'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:162:in `process'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:78:in `process_one'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/processor.rb:68:in `run'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/util.rb:15:in `watchdog'
/home/discourse/prod/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.3/lib/sidekiq/util.rb:24:in `block in safe_thread'

trying to hack but not familiar enough to be swift :slight_smile: as wished haha.

Thanks

1 Like

The code looks fine:

https://github.com/discourse/discourse/blob/6455c6ee872109fc3da9a2b45f6b7466bb96c123/lib/email/sender.rb#L117-L117

Did you follow the official installation guide? It doesn’t look like it’s running inside the Docker container.

3 Likes

no, it’s running outside. Guess I missed some steps that launcher would have run then. Thanks for checking up!

4 Likes