Reply on Original Topic - undefined

Bug
1

Hi,
I don’t know what I did exactly. I was replying a direct message while browsing some topics, and when I wanted to submit the message I had this popup:
image

It’s the first time I’ve seen it, and I’m puzzled with the “undefined”. I guess a more user-friendly message would be better. I don’t know if the undefined is a bug, a deleted topic or something else.

Also, which context this popup appears in exactly? :thinking:

3 Likes
2

My guess is that the original topic got deleted?

3

I’m puzzled. I don’t know which topic the undefined part is about, and I believe I started my message on the direct discussion page.

This is confusing. Also, I’ve written many messages on various Discourse forums and I didn’t get this popup once (which adds to the confusion), hence what I’m also asking the exact context it appears in.

As for the message itself, I’d prefer “topic not found” to “undefined”. :slight_smile:

4

I just ran into the same problem on Meta when I had the composer open in two tabs. Attempting to reply to the topic, the popup from your screenshot was displayed. That popup window is expected to be displayed, but underneath the heading, the original topic’s title should be displayed. It seems that Discourse is not finding the original topic.

reply_undefined
reply_undefined729×339 20.8 KB

When I clicked the Reply on Original Topic option, the following error was displayed:

reply_undefined_two
reply_undefined_two754×256 15.4 KB

This seems like a bug. Unless someone knows what is causing the problem, we’ll have to work out the steps to reproduce the issue. I’ll get a chance to do that today.

4 Likes
5

I can reproduce the issue on https://try.discourse.org/.

Steps to reproduce (tested with the Chrome browser on Linux):

  • browse to a topic and click the reply button to open the composer
  • start creating a reply
  • duplicate the tab
  • click the composer’s reply button from the duplicated tab
    image
    image1260×542 59.6 KB
7 Likes
9

Honestly, no idea how the ever worked, we still need a massive rewrite on composer model and controller, but at least now stuff is correctly loading and not relying on luck like it used to.

https://github.com/discourse/discourse/commit/b8d2261db9f216414b86a27d83435f4ee99561cc

11 Likes
12

This is still happening. I don’t have steps to reproduce it, but I experienced it today.

13

OK, but without a repro, what exactly can we do?

14

So I got a repro by following these steps:

  • browse to a topic and click the reply button to open the composer
  • start creating a reply
  • duplicate the tab (you can do this by right clicking on a tab)
    ---- NEW STEPS
  • click on forum logo
  • click on a other topic
  • composer should show with your previous reply
  • click the composer’s reply button (at this step you should still be on the duplicated tab)

You should see something like this:

Screenshot 2020-04-04 at 12.07.14
Screenshot 2020-04-04 at 12.07.141302×638 45.5 KB

11 Likes
16

This should fix it:

This code is all pretty fragile and very complex to test.

11 Likes