Restore backup tooltip link broken

ondrej · January 4, 2025, 10:37pm

As you can see in the image below when you create a backup and hover over the disabled ‘Restore’ button the link is missing

Would it be better if it said

Restore is currently disabled. To enable it, search for ‘allow restore’ in site settings.

Moin · January 4, 2025, 11:54pm

It looks like the title of the button was not updated when the URL was added in UX: Fix restore info link on admin backups page by martin-brennan · Pull Request #28452 · discourse/discourse · GitHub

For the banner, the URL is forwarded:

github.com

discourse/discourse/blob/53b51e0d5686df63a28759c26ae8b8547fc952e3/app/assets/javascripts/admin/addon/templates/backups-index.hbs#L20-L30


      
          {{#if this.status.restoreDisabled}}
            <div class="backup-message alert alert-info">
              {{dIcon "circle-info"}}
              {{html-safe
                (i18n
                  "admin.backups.operations.restore.is_disabled"
                  url=this.restoreSettingsUrl
                )
              }}
            </div>
          {{/if}}

However, the button title does not get a URL:

github.com

discourse/discourse/blob/53b51e0d5686df63a28759c26ae8b8547fc952e3/app/assets/javascripts/admin/addon/controllers/admin-backups-index.js#L28


      
          @setting("backup_location") backupLocation;
          @equal("backupLocation", "local") localBackupStorage;
          
          get restoreSettingsUrl() {
            return getURL("/admin/backups/settings?filter=allow_restore");
          }
          
          @discourseComputed("status.allowRestore", "status.isOperationRunning")
          restoreTitle(allowRestore, isOperationRunning) {
            if (!allowRestore) {
              return "admin.backups.operations.restore.is_disabled";
            } else if (isOperationRunning) {
              return "admin.backups.operations.is_running";
            } else {
              return "admin.backups.operations.restore.title";
            }
          }
          
          @action
          async download(backup) {
            try {

Topic		Replies	Views
Restore backup button greyed out Support	6	644	November 27, 2019
The Restore button is not activated! Support	2	432	April 21, 2019
Topic titles missing from deleted posts page when OP is deleted Bug	4	925	December 31, 2022
Why do my backups not have the "Restore" button? Support	4	375	January 15, 2023
Restore backup is broken Bug	3	885	February 15, 2021

Restore backup tooltip link broken

Related topics