Restore backup tooltip link broken

ondrej · January 4, 2025, 10:37pm

As you can see in the image below when you create a backup and hover over the disabled ‘Restore’ button the link is missing

Would it be better if it said

Restore is currently disabled. To enable it, search for ‘allow restore’ in site settings.

Moin · January 4, 2025, 11:54pm

It looks like the title of the button was not updated when the URL was added in UX: Fix restore info link on admin backups page by martin-brennan · Pull Request #28452 · discourse/discourse · GitHub

For the banner, the URL is forwarded:

github.com

discourse/discourse/blob/53b51e0d5686df63a28759c26ae8b8547fc952e3/app/assets/javascripts/admin/addon/templates/backups-index.hbs#L20-L30


      
          {{#if this.status.restoreDisabled}}
            <div class="backup-message alert alert-info">
              {{dIcon "circle-info"}}
              {{html-safe
                (i18n
                  "admin.backups.operations.restore.is_disabled"
                  url=this.restoreSettingsUrl
                )
              }}
            </div>
          {{/if}}

However, the button title does not get a URL:

github.com

discourse/discourse/blob/53b51e0d5686df63a28759c26ae8b8547fc952e3/app/assets/javascripts/admin/addon/controllers/admin-backups-index.js#L28


      
          @setting("backup_location") backupLocation;
          @equal("backupLocation", "local") localBackupStorage;
          
          get restoreSettingsUrl() {
            return getURL("/admin/backups/settings?filter=allow_restore");
          }
          
          @discourseComputed("status.allowRestore", "status.isOperationRunning")
          restoreTitle(allowRestore, isOperationRunning) {
            if (!allowRestore) {
              return "admin.backups.operations.restore.is_disabled";
            } else if (isOperationRunning) {
              return "admin.backups.operations.is_running";
            } else {
              return "admin.backups.operations.restore.title";
            }
          }
          
          @action
          async download(backup) {
            try {

Moin · September 16, 2025, 8:07pm

I just did a recheck: It’s still broken.

martin · September 22, 2025, 5:59am

Fix is here, will get it merged soon

github.com/discourse/discourse

UX: Disabled restore backup title included link HTML

main ← ux/restore-disabled-title

opened 05:58AM - 22 Sep 25 UTC

martin-brennan

+2 -1

Followup https://github.com/discourse/discourse/pull/28452 The title for the …"Restore" backup button was using HTML, the same as the alert for admins telling them that restoring is disabled. This fixes the issue by adding a plain text title a reference to the relevant site setting. c.f. https://meta.discourse.org/t/restore-backup-tooltip-link-broken/345620

Topic		Replies	Views
Restore backup button greyed out Support	6	667	November 27, 2019
The Restore button is not activated! Support	2	444	April 21, 2019
Disabling backups does not remove item from admin sidebar UX	2	75	May 22, 2025
Recovery is disabled in the site Settings Installation	4	951	August 15, 2019
Can't upload backup Support	33	2663	December 27, 2021

Restore backup tooltip link broken

Related topics