Retain launcher command past an image download?

Bug
1

Mentioned here: (that’s for pointing it out @fefrei

I just tried this, and after an image pull, ./launcher forgot what it was supposed to be doing.

<snip>
Status: Downloaded newer image for discourse/discourse:1.3.5
Usage: launcher COMMAND CONFIG [--skip-prereqs] [--docker-args STRING]
Commands:
    start:      Start/initialize a container
    stop:       Stop a running container
...

Full command output here: discourse-upgrade.log · GitHub

re-running ./launcher rebuild app worked fine, but if that could have been preserved past the image download, that’d have been extra sweet.

5 Likes
2

Yeah someone broke this :frowning: I need to fix

2 Likes
3

This is working now, just tested it.

sam@ubuntu discourse_docker % git reset --hard HEAD~2
HEAD is now at ac9d4df FIX: Show proper version on /VERSION file
sam@ubuntu discourse_docker % ./launcher rebuild app
Ensuring launcher is up to date
Fetching origin
Updating Launcher
Updating ac9d4df..e7696e0
Fast-forward
 image/discourse/Dockerfile | 18 ------------------
 launcher                   |  2 +-
 2 files changed, 1 insertion(+), 19 deletions(-)
 delete mode 100644 image/discourse/Dockerfile
Ensuring launcher is up to date
Fetching origin
Launcher is up-to-date
cd /pups && git pull && /pups/bin/pups --stdin
3 Likes