Reviewable View Full Conversation broken on subfolder installs

[cpradio]

On the Reviewable list, the view full conversation button does not work on sub-folder installs as it places the sub-folder in the URL twice.

I believe the issue happens here, though I’m not 100% sure why (other than maybe the base_url and the relative_url both include the sub-folder)

e class="onebox githubblob" data-onebox-src="https://github.com/discourse/discourse/blob/743ce093a952d42d514e6892f134d08fe88db350/lib/reviewable/conversation.rb#L23">

github.com/discourse/discourse

lib/reviewable/conversation.rb

743ce093a

      

          
        @id = post.id
          
        @excerpt = FlagQuery.excerpt(post.cooked)
          
      end
          
    end
          

          
    attr_reader :id, :permalink, :has_more, :conversation_posts
          

          
    def initialize(meta_topic)
          
      @id = meta_topic.id
          
      @has_more = false
          
      @permalink = "#{Discourse.base_url}#{meta_topic.relative_url}"
          
      @posts = []
          

          
      meta_posts = meta_topic.ordered_posts.where(post_type: ::Post.types[:regular]).limit(2)
          

          
      @conversation_posts = meta_posts.map { |mp| Reviewable::Conversation::Post.new(mp) }
          
      @has_more = meta_topic.posts_count > 2
          
    end
          
  end
          
end
      
    

Clicking on it leads to a “Oops this page doesn’t exist or is private page to load”.

Screenshot showing duplicate sub-folder in path

[codinghorror (Jeff Atwood)]

Maybe @eviltrout can have a look Monday.

[j.jaffeux (Joffrey Jaffeux)]

@eviltrout I think that should do it:

FIX: ensures url to full reviewable conversation works on subfolder

[eviltrout (Robin Ward)]

I confirmed @j.jaffeux’s fix and merged it. Should be good now! Thanks.