Reviewable View Full Conversation broken on subfolder installs

On the Reviewable list, the view full conversation button does not work on sub-folder installs as it places the sub-folder in the URL twice.

I believe the issue happens here, though I’m not 100% sure why (other than maybe the base_url and the relative_url both include the sub-folder)
https://github.com/discourse/discourse/blob/743ce093a952d42d514e6892f134d08fe88db350/lib/reviewable/conversation.rb#L23

Clicking on it leads to a “Oops this page doesn’t exist or is private page to load”.

Screenshot showing duplicate sub-folder in path

4 Likes

Maybe @eviltrout can have a look Monday.

6 Likes

@eviltrout I think that should do it:

https://github.com/discourse/discourse/pull/7797

4 Likes

I confirmed @joffreyjaffeux’s fix and merged it. Should be good now! Thanks.

6 Likes