Reviewable View Full Conversation broken on subfolder installs

cpradio · 22.Июнь.2019 12:02:13

On the Reviewable list, the view full conversation button does not work on sub-folder installs as it places the sub-folder in the URL twice.

I believe the issue happens here, though I’m not 100% sure why (other than maybe the base_url and the relative_url both include the sub-folder)

github.com/discourse/discourse

lib/reviewable/conversation.rb

743ce093a


      
                  @id = post.id
                  @excerpt = FlagQuery.excerpt(post.cooked)
                end
              end
          
              attr_reader :id, :permalink, :has_more, :conversation_posts
          
              def initialize(meta_topic)
                @id = meta_topic.id
                @has_more = false
                @permalink = "#{Discourse.base_url}#{meta_topic.relative_url}"
                @posts = []
          
                meta_posts = meta_topic.ordered_posts.where(post_type: ::Post.types[:regular]).limit(2)
          
                @conversation_posts = meta_posts.map { |mp| Reviewable::Conversation::Post.new(mp) }
                @has_more = meta_topic.posts_count > 2
              end
            end
          end

Clicking on it leads to a “Oops this page doesn’t exist or is private page to load”.

Screenshot showing duplicate sub-folder in path

codinghorror · 22.Июнь.2019 13:28:27

Maybe @eviltrout can have a look Monday.

j.jaffeux · 24.Июнь.2019 10:40:04

@eviltrout I think that should do it:

https://github.com/discourse/discourse/pull/7797

eviltrout · 24.Июнь.2019 15:32:27

I confirmed @j.jaffeux’s fix and merged it. Should be good now! Thanks.

Тема		Ответов	Просм.
Button to share conversation in AI conversation not respecting sub folder setup Bug subfolder , ai	2	185	06.06.2024
Discourse rewriting url path behaviour failing due to subfolder Bug subfolder	9	1531	08.08.2018
Links without sub-folder path in embedded comments (Continue Discussion and user links) Bug	5	1670	13.01.2016
Subfolder install using certain keyboard shortcuts results in Page Not Found until you refresh the page Bug subfolder , keyboard-shortcuts	3	875	08.06.2017
Site relative paths rewritten client side incorrectly with subfolder Bug subfolder	15	1376	16.06.2021

Reviewable View Full Conversation broken on subfolder installs

Связанные темы