S3 uploads incompatible with server-side encryption

JammyDodger · July 7, 2023, 11:27am

I think this has now been merged.

github.com/discourse/discourse

FIX: don't use etags for post-upload verification

discourse:main ← mpalmer:no-etag

opened 02:13AM - 05 Jun 23 UTC

mpalmer

+8 -15

They don't work for server-side encryption with customer keys, and so instead we… just use Content-MD5 to ensure there was no corruption in transit, which is the best we can do. See also: https://meta.discourse.org/t/s3-uploads-incompatible-with-server-side-encryption/266853 No tests were changed because, as far as I can tell, there are no tests for this area of the codebase.

Topic		Replies	Views
Help restoring - system hung at midnight installation	26	2025	June 13, 2022
S3 image upload access denied while backups upload working fine installation s3	22	2440	March 23, 2020
User cannot use custom avatar with Amazon S3 bug	42	6242	May 4, 2015
Restore process cancelled at migrating uploads to S3 step support	25	2364	April 24, 2021
Restore failed at "EXCEPTION: x of y uploads are not migrated to S3. S3 migration failed for db 'default'." installation	4	925	June 10, 2022

S3 uploads incompatible with server-side encryption

Related Topics