Saving Draft New Topic

Rhidian · June 20, 2021, 5:19am

Priority: Low

Platform: Discourse mobile iOS (not tested on other platforms). Reproduced in Discourse meta and try.Discourse.org

Description: Save a draft New Topic when prompted. Open Draft button doesn’t work.

Reproducible steps:

Go to Discourse home page.
Click + New Topic
Type in subject line ‘Testing Drafts’. Type in composer body ‘Testing’. Leave as uncategorised.
Click Cancel (bin icon on Discourse mobile). You are asked if you want to Save a draft for later - click that option.
The + New Topic button changes to + Open Draft.
Click + Open Draft. Nothing happens.
Check Drafts folder - no draft is saved.

Consequence: This left me temporarily unable to create a new Topic.

Workaround: Clicking the inactive + Open Draft button a number of times eventually crashes Discourse site in mobile app and returns to domain selection. Return to Discourse - the + Open Draft has cleared and is back to + New Topic.

jean.perez · June 22, 2021, 1:26am

The title is not lengthy enough to pass this validation

github.com

discourse/discourse/blob/master/app/assets/javascripts/discourse/app/models/composer.js#L1184

    
      
          if (this.disableDrafts) {
            return Promise.resolve();
          }
          
          
if (this.canEditTitle) {
            // Save title and/or post body
            if (isEmpty(this.title) && isEmpty(this.reply)) {
              return Promise.resolve();
            }
          
          
  // Do not save when both title and reply's length are too small
            if (!this.titleLengthValid && this.replyLength < this.minimumPostLength) {
              return Promise.resolve();
            }
          } else {
            // Do not save when there is no reply
            if (isEmpty(this.reply)) {
              return Promise.resolve();
            }
          
          
  // Do not save when the reply's length is too small

But I wonder, why is the code resolving instead of rejecting and then catching errors?

I think errors can be caught here

github.com

discourse/discourse/blob/master/app/assets/javascripts/discourse/app/controllers/composer.js#L1244

    
      
                // in test debounce is Ember.run, this will cause
                // an infinite loop
                if (!isTesting()) {
                  this._saveDraftDebounce = discourseDebounce(
                    this,
                    this._saveDraft,
                    2000
                  );
                }
              } else {
                this._saveDraftPromise = model.saveDraft().finally(() => {
                  this._lastDraftSaved = Date.now();
                  this._saveDraftPromise = null;
                });
              }
            }
          },
          
          
@observes("model.reply", "model.title")
          _shouldSaveDraft() {
            if (

something along these lines

this._saveDraftPromise = model.saveDraft().then(() => {
    this._lastDraftSaved = Date.now();
    ...
}, error => {
    // error handling here
}).finally(() => {
    this._saveDraftPromise = null;
});

@eviltrout any thoughts?

eviltrout · June 22, 2021, 1:12pm

This saving code is unfortunately some of our oldest, and often our most fragile. Over the years we’ve layered lots of functionality on it, and some things like saving drafts which can succeed or fail need their own custom functionality which just complicates it even more.

I think your intuition is probably right here, but it’s impossible for me to confirm without seeing how all our tests run. If you have time for a PR in the future that would be great.

SonsOfAhriman · June 23, 2021, 1:14pm

Was able to reproduce this bug in MacOS Chrome on Discourse meta following Rhidian’s steps as below:

nbianca · August 3, 2021, 2:57pm

Hello,

Thank you for the bug report. It was fixed in the latest version of Discourse. The problem was that it offered to save very short drafts even when this is not supposed to happen.

nbianca · August 7, 2021, 8:00am

This topic was automatically closed after 3 days. New replies are no longer allowed.

Topic		Replies	Views
Persistent text composition box in different instances of Discourse Feature	8	1456	July 3, 2014
Reducing the frequency of display for the warning "Draft is being edited in another window." Feature	34	2552	December 4, 2023
Post won't save (text included) Bug	19	2411	April 3, 2016
"+Create Topic" button scary UX	27	1343	February 22, 2024
Allow multiple ‘new topic’ drafts Feature drafts	41	4024	October 15, 2024

Saving Draft New Topic

Related topics