Search Parameters Removed On Search


(Alex Sherwood) #1

Since the release of version 1.8 I’ve noticed that the search parameters group:[group name] & @username (I haven’t checked others) that have been typed into the search bar, are removed from the search box itself & the query summary, when I execute a search -

becomes

though the parameter is still applied to the search.

But if I then change the result’s Sort By (blue box above), the parameter is not applied to the search so I have to keep adding it back into the query if I do this or want to try a different search term.

Presumably this is a bug? (Apologies if this has been posted already, I did look).


(Jeff Atwood) #2

Any thoughts here @cpradio?


(cpradio) #3

Possibly the Ember upgrade?

It seems I have fixed this once before, not sure why it no longer works though


(cpradio) #4

I think I’ve proven it now. I just loaded the following commit:
SECURITY: theme key should be an anon cache breaker · discourse/discourse@ac1f84d · GitHub

Which is immediately before the Ember 2.13 upgrade and the search operators are maintained. I’m about to upgrade to Upgrade Ember to 2.13 · discourse/discourse@8ae4457 · GitHub to verify they disappear, but at the very least, I know for a fact, it just broke recently.

Edited:
Welp, that sounded good in theory, but it seems to not be entirely true, I’m not 100% sure when this broke now. I discovered if you do a hard refresh, and then use the search icon, and click Show More, the parameters transfer fine. Once you click the search button on the full page search… they disappear, and they continue to disappear on all future searches too. This is very bizarre.


(Jeff Atwood) #5

Probably good for @eviltrout to have a look


(Robin Ward) #6

This is result of the patch that removed hidden whitespace from search terms. Here’s a fix:


(Robin Ward) #7