Selected text is overwritten when using the link toolbar action


(Markus) #1

Hello,

Since the latest github commits, it seems, there is something broken. Workaround:

By selecting a few words and trying to insert a hyperlink with the symbol bar icon, I’ve got a problem: The link I’ve copied before will overwrite the selected text, insted of filling the text field of the hyperlink prompt.

Result:
If I wrote more than just a few words and overwrite them, they will be lost for ever! I can’t undo this to restore my text. :sadpanda:


(Jeff Atwood) #2

Aha that does seem like a regression, but the temporary workaround is to not do that for now. How is this “urgent”?


(Markus) #4

I would say, the link prompt is one of the most important functions at our Discourse instance. Especially for mobile / tablet users.


(Vinoth Kannan) #5

Hello Markus,

I am able to understand the issue now. I am checking it. Thanks for reporting it.


(Markus) #6

Thank you very much!!! :slight_smile:


(Vinoth Kannan) #7

Also as a workaround you can use “Paste as plain text” from context menu or Ctrl + Shift + V to skip HTML pasting.


(Markus) #8

Thanks for the hint. :slight_smile:

Is it possible to generally disable HTML pasting? It seems to take much longer then before and won’t be kind of necessary / useful for us.

Maybe some kind of an integrated undo option inside the composer would be useful?


(Vinoth Kannan) #10

It is fixed now :+1:.

Currently there is no option to disable it. But you can always use the two workarounds above for plain text pasting.


(Jeff Atwood) #11

Can this be sped up @vinothkannans? Can there be a quick reject check where the code running sees that none of the special characters / data necessary for a fancy paste are present, and then it exits that code path to the traditional fast paste?


(Vinoth Kannan) #12

It’s done. Now HTML to Markdown conversion happening silently in background. So no more waiting.


(Sam Saffron) #13

I do like this a lot, I wonder though if long term we want to do this stuff in JavaScript both on server and client side. It just adds a tiny bit more polish to a wonderful feature.

Nothing urgent, something to think about longer term.


(Jeff Atwood) #14

Is this fixed now, or should still be open?


(Markus) #15

Solved. Thanks guys! :heart:


(Jeff Atwood) #16