Should a deactivated user receive an email?

[sam (Sam Saffron)]

The context for the change appears to be:

Account activation / email verification email not sent on sign up, when "must approve users" option is turned on

I’ve turned on the “must approve users” options in my login options. When this is turned on, the email verification emails don’t get sent, so user accounts sit as inactive. The message to the user after signing up is: Thanks for signing up. We will notify you when your account has been approved. In order to allow the newly created account, I need to activate it, then also approve it. This seems… a bit much, especially since activating an account is sat inside the admin page for the individu…

So “must approve users” relies on “admins” to actually do the email validation.

My gut here is that the change to fix is rather complex.

• Must approve users - should only get users that have validated emails
• Hence even if this setting is enabled we should validate emails first prior to passing on users to admins

Which would be a major rework of this feature. Not against this by any means but it feels somewhat complex.