Sidebar theme toggle

It should already work on mobile devices, but let us know if there are any issues!

3 Likes

Well… it doesn’t :wink: Not here, not on my own.

2 Likes

ah I see, I’ll have to double check the app, looks like the footer’s getting cut off there… thanks for mentioning it!

3 Likes

You are totally right. The issue is the Hub.

1 Like

This is a great idea for a component, but I’m having a little difficulty getting it to work. I’ve installed it and included it in all my themes but the drop-down doesn’t appear. If I toggle the “hide theme name” setting, the keyboard shortcut icon moves from the left side of the sidebar footer to the right, but no theme selector.

1 Like

Thanks Kris, unfortunately it’s not working on my site. Did a hard refresh of course, tried different themes that have no other components, don’t see anything relevant in the console or logs…

1 Like

Rebuild your instance. It will fix all of the issues mentioned above so far.

2 Likes

oh yes, I should have mentioned that if you haven’t updated Discourse in the past few days you should do that as well

4 Likes

I think I’m on the most recent version…

Screenshot 2022-10-24 at 18.32.16

I’ll try rebuilding later. Our users tend to freak out a bit if the site goes offline with no warning.

3 Likes

You should consider this :sunglasses:

2 Likes

What about a dark theme selector? For light, dark and auto. That seems broken since I switched to the sidebar.

1 Like

A post was merged into an existing topic: While loading a new component on the site, the site is down

Hello,

Thanks for the component :slightly_smiling_face:

I have noticed a little issue with it. It seems on mobile (I tested on Android 10 Chrome 109.0.5414.117 and iOS 16.1.1 Safari) it only scrollable if the sidebar is scrollable. When the sidebar sections are collapsed the theme toggle is not scrollable for me. Thank you :slightly_smiling_face:

3 Likes

Is it still the case? I can’t repro on my android phone.

1 Like

I can. I cannot scroll if all sections are collapsed

If the sidebar is scrollable, the menu to choose a theme is too

4 Likes

I misunderstood the issue and I after trying again, I experience it as well.

2 Likes

I’ve added a fix here:

I’ve updated the component on Meta, and it works fine for me on mobile now! Thanks for reporting it everyone!

3 Likes

Hi, there has been a regression in the past few days of Discourse commits where the browser / OS scrollbar appears always visible with a few pixels of vertical slop when the Sidebar Theme Toggle is enabled. It’s happening here on Discourse Meta and also on my forum, currently on 3.1.0.beta3 (6b5743ba3c). It happens with Firefox and Chromium. I imagine that nobody has noticed it because most OSes these days are defaulting to skinny / disappearing scrollbars, but I’m rather old-school. :sunglasses:


Edit: Looks like I can get rid of it with this quick dirty workaround for now:

.sidebar-footer-container {
    padding-bottom: .5em !important;
}
1 Like

I just made a minor update to fix this

1 Like

Thanks a lot @awesomerobot for the quick fix! Works great.

1 Like