Sidekiq email error: no implicit conversion of nil into String

daath · March 2, 2016, 12:26am

I suddenly got a whole bunch of these errors after I updated last:

Jobs::HandledExceptionWrapper: Wrapped ActionView::Template::Error: no implicit conversion of nil into String

Screenshot:

watchmanmonitor · March 2, 2016, 4:12am

I’m getting the same thing…

this is in my /logs:

/var/www/discourse/app/views/user_notifications/digest.html.erb:76:in `+'
/var/www/discourse/app/views/user_notifications/digest.html.erb:76:in `_app_views_user_notifications_digest_html_erb__4452730389243201084_70167469511260'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/template.rb:145:in `block in render'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/notifications.rb:164:in `block in instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/notifications.rb:164:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/template.rb:333:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/template.rb:143:in `render'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/rack-mini-profiler-0.9.8/lib/mini_profiler/profiling_methods.rb:77:in `block in profile_method'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/renderer/template_renderer.rb:54:in `block (2 levels) in render_template'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/renderer/abstract_renderer.rb:39:in `block in instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/notifications.rb:164:in `block in instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/notifications.rb:164:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/renderer/abstract_renderer.rb:39:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/renderer/template_renderer.rb:53:in `block in render_template'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/renderer/template_renderer.rb:61:in `render_with_layout'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/renderer/template_renderer.rb:52:in `render_template'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/renderer/template_renderer.rb:14:in `render'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/renderer/renderer.rb:42:in `render_template'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/renderer/renderer.rb:23:in `render'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/rendering.rb:100:in `_render_template'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/rendering.rb:83:in `render_to_body'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.2.5.1/lib/abstract_controller/rendering.rb:25:in `render'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionmailer-4.2.5.1/lib/action_mailer/base.rb:904:in `block in collect_responses'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionmailer-4.2.5.1/lib/action_mailer/base.rb:918:in `each'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionmailer-4.2.5.1/lib/action_mailer/base.rb:918:in `each_template'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionmailer-4.2.5.1/lib/action_mailer/base.rb:900:in `collect_responses'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionmailer-4.2.5.1/lib/action_mailer/base.rb:829:in `mail'
/var/www/discourse/lib/email/message_builder.rb:9:in `build_email'
/var/www/discourse/app/mailers/user_notifications.rb:92:in `digest'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.2.5.1/lib/abstract_controller/base.rb:198:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.2.5.1/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/callbacks.rb:88:in `__run_callbacks__'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/callbacks.rb:778:in `_run_process_action_callbacks'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/callbacks.rb:81:in `run_callbacks'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.2.5.1/lib/abstract_controller/callbacks.rb:19:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.2.5.1/lib/abstract_controller/base.rb:137:in `process'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.2.5.1/lib/action_view/rendering.rb:30:in `process'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionmailer-4.2.5.1/lib/action_mailer/base.rb:596:in `block in process'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/notifications.rb:164:in `block in instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.5.1/lib/active_support/notifications.rb:164:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionmailer-4.2.5.1/lib/action_mailer/base.rb:593:in `process'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionmailer-4.2.5.1/lib/action_mailer/base.rb:584:in `initialize'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionmailer-4.2.5.1/lib/action_mailer/message_delivery.rb:25:in `new'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionmailer-4.2.5.1/lib/action_mailer/message_delivery.rb:25:in `__getobj__'
/usr/local/lib/ruby/2.0.0/delegate.rb:70:in `method_missing'
/var/www/discourse/lib/email/sender.rb:30:in `send'
/var/www/discourse/app/jobs/regular/user_email.rb:41:in `execute'
/var/www/discourse/app/jobs/base.rb:154:in `block (2 levels) in perform'
infobacktraceenvSolve  Delete  Protect Share

sam · March 2, 2016, 4:17am

aha looks like a change we pulled in via @joebuhlig regarding setting colors for links… having a look at patching it.

sam · March 2, 2016, 4:26am

What does this return?

./launcher enter app
rails c
> ColorScheme.hex_for_name('tertiary')

watchmanmonitor · March 2, 2016, 4:39am

 ColorScheme.hex_for_name('tertiary')
=> "0088cc"

sam · March 2, 2016, 4:43am

Weird … can you do a full rebuild?

Then try triggering digests in scheduled jobs under /sidekiq does the issue go away?

What could somehow happen is that an old sidekiq is somehow running using the old code that was not loading up that value.

watchmanmonitor · March 2, 2016, 5:06am

the full rebuild seemed to work… the jobs I’ve retried are being sent

steko · March 8, 2016, 7:32pm

Today I had the same exact problem and after a rebuild sidekiq started working normally again.

Sander78 · April 16, 2016, 5:12am

I’m afraid this problem still persists… Latest commit and multiple rebuilds didn’t help.

danielfilho · April 18, 2016, 6:04am

same for me.
tried to rebuild, but problem persists.

pjv · April 19, 2016, 12:48pm

I just experienced this immediately after (and as far as I can tell, as a result of) a rebuild.

h1onE · April 21, 2016, 4:04pm

~~I have the same problem…~~ After updating to latest my errors seem to be gone.

watchmanmonitor · April 24, 2016, 10:08pm

These just came back on one of my instances, updating to latest didn’t help, I have rebuilt since the first time I found them… if not more than once.

georgiano · April 26, 2016, 6:38pm

Have exactly same problem afrer updating to 1.5.1
Rebuild does not help

tuttle · April 27, 2016, 8:53pm

Same here on 1.6.0.beta2

joebuhlig · April 27, 2016, 9:09pm

I’m not real familiar with how Sidekiq works on the emails but it seems like it’s queueing up the email and sending it later. Because there’s been a lot of work on the digests lately, is it possible that the queued email is trying to use new or updated methods on send? That’s my best guess at this. I’m simply hoping this triggers an idea for someone who knows it better.

techAPJ · April 28, 2016, 6:00am

I will try to repro this issue and push a fix. Added on my list.

techAPJ · April 28, 2016, 4:59pm

Even though I am unable to repro this issue locally or on a test instance (before/after rebuild), I just pushed a fix that will solve no implicit conversion of nil into String issue:

https://github.com/discourse/discourse/commit/2a2b0d780346542d8a8389ab5cc09110269c7149

The above fix will prevent raising exception and will ensure that digest email is sent even if @anchor_color is nil. Anchor color will fallback to default color (006699).

This is not a definitive fix, as I am not sure why Sidekiq is not loading @anchor_color's value in some cases.

Topic		Replies	Views
Email jobs failing after updating to latest Support	8	734	September 7, 2019
Getting type errors in sidekiq queue Bug	9	1005	March 12, 2018
Sidekiq jobs are failing for 1 of my users Installation	12	2047	November 16, 2016
Sidekiq not running Installation	22	5186	June 8, 2024
Errors on a forum I volunteer with Support	2	643	December 22, 2023

Sidekiq email error: no implicit conversion of nil into String

Related topics