Slightly less wide tag chooser

On meta, I discovered a new UX difference: the tag chooser is slightly less wide than the title field and category chooser.

8 Likes

Probably sk2 cc @joffreyjaffeux

7 Likes

Actually that’s been around for a while as I recall but we should fix it.

9 Likes

I think it’s two problems

  1. select-kit 2 is forcing the tag input onto a separate line by default

  2. The longer-standing issue is that sometimes tags get pushed onto their own line when there’s a long category name, and at that point the left margin on the tag input is no longer needed. There’s no good way to account for that variability in flexbox… for mobile maybe we just force it to always be two-columns and truncate (I think it might have been that way before?).

    This isn’t a problem with grid, so at some point updating those inputs to use grid would allow it to be more flexible with fewer issues (probably best after we drop IE support)

8 Likes

Pushed a minor fix for this, so categories and tags will be on the same line for mobile

https://github.com/discourse/discourse/commit/1e20bdec577650e77fa3e848e74681e512779789

I think for the next release I’ll rework this in grid… and at that point the inputs will be able to wrap if needed without worrying about the extra left/right margin. I’ll use @supports(grid) so older browsers will fall back to the current flex implementation.

11 Likes