Soundcloud onebox too tall?

bug
1

Just noticed that after a recent pupdate, the height for the Soundcloud onebox iframe is too ‘tall’ at 400 leaving a lot of blank space at the bottom:

soundcloud.png282×868 12.2 KB

Not sure what changed with the recent updates, but looking at the source it looks like the height in the iframe is the cause of the extra blank space:

<iframe width="100%" height="400"
2 Likes
2

I seem to remember we had special adjustments for this @techapj?

1 Like
3

This was regressed 3 days ago in this commit. Fixed via:

https://github.com/discourse/onebox/commit/c9827e4f575036970e5430110b73eeb782facb0c

Thanks for reporting it @mr8! :thumbsup:

4 Likes