On the intfiction.org Discourse forum, we talk a lot about puzzley adventure games, so the [spoiler] tag is a big help. In this topic there are tons of separate spoiler tags, one for each hint.
This page performs okay-ish on Google Chrome, but it performs badly on Firefox, and it doesn’t perform well on slow Android phones, either. It’s crazy slow on Firefox on Android. (Scroll down a bit to see what I mean.)
This is probably Firefox’s fault.
Nonetheless, I think the spoiler plugin should set spoiler text to use color: black; background: black instead of filter: blur(0.5em) on browsers/platforms that handle blur slowly/poorly (Firefox, Android)
With CSS this should get what you described with a background that matches the text. Adding this to a theme component should override the plugin’s CSS… though it wouldn’t work for images in spoilers.
This would make the change in all browsers, you’d need to detect the user-agent in JS if you’d want to only target Firefox.
.spoiler-blurred {
filter: none;
background: var(--primary);
color: var(--primary);
}
.discourse-no-touch .spoiler-blurred:hover {
filter: none;
/* you could add a different hover effect here */
}
.spoiled {
background: transparent;
}
It’s a shame to hear about the bad Firefox performance. We don’t officially support Firefox on Android, but it looks like it impacts Firefox everywhere. Maybe we should consider going back to our old method of using a text-shadow to create the blue instead of filter…
What about an update to the mod to add a style check box for “blur spoilers/redact spoilers” - redact spoilers would cover spoiler text with a black bar that might save the browser from the overhead of rendering the text with a blur?
That would at least make it possible to create a specific “mobile” theme that could take all the speedier and mobile specific mods.
To be clear, I repro the slow-blur bug 925025 on that test page in Firefox 79.0 for macOS Catalina 10.15.5 on a 2019 MacBook Pro 16".
Firefox takes 96,141ms for a blur run; Chrome takes 9,998ms. Maybe this is fixed in nightly?
EDIT: Yup, it is. On 81.0a1 (2020-08-10) (64-bit), the attachment benchmark takes 10,006ms and the Discourse page full of spoilers renders quite smoothly.
So it sounds like maybe we should do nothing for now and just wait for Mozilla to roll out their fixes.
.