Staff color applies to quoted message

bug
1

A post was written by staff member. The post is a response to another post (by non-staff member) and has the “in response to X” symbol at the top right corner. (As it happens, the message is the one right above it.) Clicking the symbol opens up the message again on top of the message (showing the message to which the post is a reply to).

The post by staff member had staff color added. The color applied (bug!) to the replied message as well.

Screenshot:

Screenshot from 2017-01-14 20-22-19.png971×789 68 KB

2

This might be fixed with @awesomerobot’s latest change?

1 Like
6

Wait this isn’t a proper test because you are staff. You need to reply as a regular user.

8

OK now we have repro @awesomerobot not sure if fixable in CSS without contortions…

1 Like
9

I think it is easy enough to apply a CSS fix for this.

The reverse direction is hard though cause embedded posts now don’t have the correct class applied. (which is a seperate bug)

3 Likes
10

Just pushed a quick fix by adding additional specificity.

For future reference:

  • Selecting the nested replies: easy, because there’s .embedded-posts wrapping them
  • Selecting the parent post’s cooked content: easy, because it’s wrapped by .regular
  • Selecting the parent post’s avatar/meta: a little annoying, because there’s nothing distinguishing them from the .embedded-posts avatar/meta. At some point we should either expand the .regular wrapper to include the parent’s avatar/meta and cooked content, or just add a .regular class to them.
5 Likes
11

Does not seem to be working yet @sam are builds not being pushed out?

12

Yeah our build was broken, I amended our internal process to remind us once an hour if the build is broken.

4 Likes