Strike-through text is not rendered in diff

When you change a text by striking-through something, it is not visible in Diff view. You can spot it using Raw view, but I don’t see a reason why shouldn’t it be rendered in the wysiwyg view.

4 Likes

Hi @tvavrda, I assume you mean this?

it shows the words that were changed but not the actual strikethough edit itself.

3 Likes

Yes, that is exactly it. I was waiting until my original article will allow to see diffs to show it :slight_smile:

3 Likes

This will fix it! UX: show strikethrough, underline in post edit diff by awesomerobot · Pull Request #30773 · discourse/discourse · GitHub

Thanks for the report

5 Likes

Seems to still have the problem in the “old” version. So when cancel strike-through.

I also noticed some problems with diff when e-mail addresses are in but I cannot reproduce so far (without showing sensitive data). I might experiment on that.

1 Like

ah yes, missed a case… this will fix it soon: UX: remove redundant `text-decoration: none`, follow up to 912b002 by awesomerobot · Pull Request #30775 · discourse/discourse · GitHub

6 Likes

Thanks! Works beautifully in all kinds of combinations.

2 Likes

This topic was automatically closed after 2 days. New replies are no longer allowed.