Suggestion : Topic History Modal

(Rob Meade) #1


Sometimes I need to Hide Revision on lengthy topics, as such, I have to scroll to the bottom of the post within the History modal in order to click the button, if a slight tweak was made to this modal, I wouldn’t need to.

Instead of doing this;

Could we have this?

You’ll note that the footer of the modal which contains the buttons is separate from the scroll bar, as per the header of the modal which contains the Close button and the heading;

This would still allow for reviewing of the entire topic where necessary but also provide the ability for quick action by having the buttons visible without scrolling.

Thanks in advance :slight_smile:

(Jeff Atwood) #2

Sure great idea, is this possible @awesomerobot ?

(Rob Meade) #3

Thanks Jeff, obviously I hope it wouldn’t only benefit myself :wink:

(Joshua Rosenfeld) #4

I swear I requested this before (can’t find it right now…), but while we’re making the footer sticky, it’d be nice to also make the header sticky - particularly the previous/next buttons. For the same reasons @RobMeade brings up, it’d be nice to be able to change revisions without needing to scroll up all the way. Very useful when comparing multiple long edits. Bonus points if the history modal remembered where it was scrolled to when changing revisions :smiley:.

Edit: Found it!

Seems I had similar issues finding this request back in June :wink:.

(Jeff Atwood) #5

Can’t say I agree with that – make everything “sticky” and there’s no display room for anything else.

We should pick one, though.

(Joshua Rosenfeld) #6

I agree. Let me make a quick mockup of an idea.

(Rob Meade) #7

I must confess, on this one I didn’t think to search first before posting, sorry - I normally try to to prevent duplicating.

Thanks both for the support with this one, look forward to seeing a mockup :slight_smile:

(Jeff Atwood) #8

Sure we can combine these topics, then.

(Joshua Rosenfeld) #10

Umm…don’t think we should. My request is buried in a topic about wiki improvements…unless someone can find my original request for this feature.

(Jeff Atwood) #11

Oh you’re right, that one should be closed because the default action on wiki posts is now edit (rather than reply). My bad.

(Joshua Rosenfeld) #13

Here’s our current edit history modal when scrolled to the top:

and here’s the modal when scrolled down:

The “controls” area takes up over 100px for the previous and next buttons as well as the user who edited it. The footer takes up ~60px.

Instead of making both the header and the footer sticky, perhaps we can collapse the controls into the already sticky header (that currently says “History”) like so:

Scrolled up view

Scrolled down view

When scrolled all the way to the top the modal should look as it currently does, but with the sticky footer. When scrolled down we should collapse the previous, next, user, and view type buttons into the header.


(Rob Meade) #14

I like the idea, my initial criticism (sorry), is that you lose the revision # / ## indication. Possibly not the be all and end all, perhaps if there isn’t room for it, could it appear when you hover over the controls?

I rarely use the history functionality on my mobile, but would this be a consideration also, e.g making sure someone like myself with large, ape-like, thumbs doesn’t hit the wrong buttons? :slight_smile:

(Joshua Rosenfeld) #15

No need to apologize - feedback is good!

So nothing is being lost - when scrolled to the top you should see the full “controls” area like you do now. (I see that my mockup is confusing because it’s scrolled to the top…I’ll fix that fixed). Only when scrolled down would the controls collapse. I’m not against adding more info to the collapsed header, we’d just have to ensure that it all fits.

Mobile is a whole different issue. We show a desktop-sized modal that requires scrolling sideways to see everything. I’m all for improving it but that may need a topic of its own - it’s not pretty right now.

(Rob Meade) #16

Gotcha, in that case this sounds good to me… :slight_smile:

(Kris) #17

Appears to be a fairly simple enhancement to make, I should be able to add it this week. Thanks again, @RobMeade!

(Rob Meade) #18

Fantastic, many thanks :slight_smile:

Post History - Regression?
(Kris) #19

Made this change earlier in the week.

(Kris) closed #20