Support for full_screen_login feature like saml plugin

[trobiyo (Ismael Posada Trobo)]

@eviltrout, any plans to add full_screen_login feature like saml plugin (https://github.com/discourse/discourse-saml/blob/master/plugin.rb)?

[eviltrout (Robin Ward)]

It’s not on my list in the foreseeable future. Maybe someone from the community can help out here.

[Nick_Shearer_nsheare (Nick Shearer)]

I made a couple of PRs that would support this. Seems like it’s not possible to do it exclusively from the plugin side (unless all oauth2-basic plugins were full screen).

PRs are up at:

https://github.com/discourse/discourse/pull/6180
https://github.com/discourse/discourse-oauth2-basic/pull/14

in case anyone wants to have a look at em.

Maybe there is a cleaner way but it wasn’t apparent to me.

Would resolve some UX issues around the popup window for those of us exclusively using an OAuth2 login.

Cheers,

Nick

[david (David Taylor)]

Those PRs are now both merged. Thanks for the contributions @Nick_Shearer_nsheare

[Nick_Shearer_nsheare (Nick Shearer)]

thanks for the help!