Hey folks, we’re running hosted Discourse using only GitHub authentication. We’ve successfully added functionality to our own platform to delegate authentication to our system using OAuth2, and our goal is to switch from GitHub auth to OAuth2, and hoped that users logging in using OAuth2 with the sa…

Have you enabled the “oauth2_email_verified” setting? If not, then Discourse won’t trust the email addresses from the OAuth provider, and will display the create account dialog instead.

Yep we did find that setting: [image] All of the testing I listed was performed with that setting on.

It is surprising that the error message is “Please enter a valid email address”. That suggests that the email address is invalid, rather than matching an existing account. To debug, I would suggest comparing the email address in the OAuth2 debug logs, to the emails in the database. If it works for …

Thanks for the reply! Sorry, I think that email address error must have been an error from a previous iteration of testing. After a hard refresh and another attempt, this is what I see (and have seen in other cases): [image] Note that the username is automagically-appended with a number to make …

[изображение] cori: Anything else I can look at? The logic for matching by email address can be found here: plugin.rb main # frozen_string_literal: true # name: discourse-oauth2-basic # about: Allows users to login to your …

Ok, I think I see where the problem is, at least for some of these records; my test plan has been: sign up in Discourse with new users from the OAuth process in each of 3 different scenarios (our platform has a few different signin scenarios that I wanted to test) delete those users using the Admi…

Thanks for the detailed repro! :female_detective: [изображение] cori: when deleting the users from the Admin UI, it doesn’t remove the corresponding rows from the plugin_store_rows table Would that be considered a bug @david ?

Yes, I think so. Although it is fairly unlikely to occur in a “real” environment. It will certainly be fixed when we migrate the plugin to ManagedAuthenticator.

This should now be fixed, thanks to @angus :smiley: https://meta.discourse.org/t/oauth2-basic-support/33879/189?u=david

Switching from GitHub auth to OAuth2

Поддержка SSO

david (David Taylor) 29.Июль.2019 09:39:45 11

Теперь это должно быть исправлено, спасибо @angus

https://meta.discourse.org/t/oauth2-basic-support/33879/189?u=david

Тема		Ответов	Просм.
When I use Oauth2 login, If I already have a account , I want to connect them by email Support	1	1521	30.04.2021
OAuth-based login: Disable account merging Feature	5	1293	27.02.2016
Discourse-oauth2-basic Login Inconsistencies SSO oauth2	3	671	18.11.2019
Login to Discourse with custom Oauth2 provider Feature oauth2 , completed	22	274376	06.07.2020
Discourse SSO with OAuth2 Support	4	3236	03.11.2019

Switching from GitHub auth to OAuth2

Связанные темы