Theme lint fails because -- Could not find "@discourse/lint-configs/stylelint"

Dev
1

I’ve got a theme component that started from a skelton a few days ago. It seemed to pass the tests when I ran it locally, but at github it failed. So I ran mass-pr to update the theme stuff and now it’s failing and it looks like it’s not my fault:

Run if test -f stylelint.config.mjs; then
  if test -f stylelint.config.mjs; then
    pnpm stylelint --allow-empty-input "{javascripts,desktop,mobile,common,scss}/**/*.scss"
  fi
  shell: /usr/bin/bash -e {0}
  env:
    JS_PKG_MANAGER_NULL_VALUE: none
Error: Could not find "@discourse/lint-configs/stylelint". Do you need to install the package or use the "configBasedir" option?
    at configurationError (file:///home/runner/work/right-sidebar-blocks-customization/right-sidebar-blocks-customization/node_modules/.pnpm/stylelint@16.14.1_typescript@5.8.2/node_modules/stylelint/lib/utils/configurationError.mjs:12:49)
    at getModulePath (file:///home/runner/work/right-sidebar-blocks-customization/right-sidebar-blocks-customization/node_modules/.pnpm/stylelint@16.14.1_typescript@5.8.2/node_modules/stylelint/lib/utils/getModulePath.mjs:29:9)
    at loadExtendedConfig (file:///home/runner/work/right-sidebar-blocks-customization/right-sidebar-blocks-customization/node_modules/.pnpm/stylelint@16.14.1_typescript@5.8.2/node_modules/stylelint/lib/augmentConfig.mjs:225:21)

Is there something I can do?

3 Likes
2

Just looking at your package.json, looks like the version on the @discourse/lint-configs regressed to "@discourse/lint-configs": "2.4.0".

The latest lint-configs version is actually 2.11.0

2 Likes
3

Ah, we haven’t merged the mass-pr changes for stylelint yet. But we did update the skeleton. So running the main version of mass-pr has taken your repo backwards :sweat_smile:

There’s a PR in progress here, so you could probably check that out and use it to repair things.

(@cvx can we merge this PR? Or is there more to add still?)

2 Likes
4

I was thinking that the mass pr pulled from the skeleton. I’ll try to pay closer attention.

1 Like
5

Pushed all remaining changes, ready for a re-review!

That’s correct, but it only copies some of the files (files it knows about) :smiley:

4 Likes