There was an error. Your site may not work properly. Caused by plugin 'discourse-whos-online'

Contribute Bug

AI-generated summary

The discussion revolves around an error message caused by the ‘discourse-whos-online’ plugin, visible only to site administrators. Geoffrey_Challen initially reported the issue, and Arkshine suggested checking if the plugin is up to date. After confirming the plugin is updated, Arkshine asked Geoffrey_Challen to check the browser’s console for errors. Arkshine was unable to reproduce the issue on a clean production instance but found an error on a dev instance, which seemed to be related to the direct use of ‘et’ on a pre-defined object. The issue appears to be addressed by a pull request, as mentioned by saquetim.

1

The image shows an error message indicating that a site may not work properly, caused by a plugin named 'discourse-whois-online,' and is visible only to site administrators. (Captioned by AI)
The image shows an error message indicating that a site may not work properly, caused by a plugin named 'discourse-whois-online,' and is visible only to site administrators. (Captioned by AI)1102×170 23 KB

Just started seeing this recently. On 3.4.0.beta4-dev, and have been updating dilligently. Any idea where I should look for trouble?

2 Likes
2

Hey Geoffrey,

Is the plugin up to date?

The latest version is:
image

3 Likes
3

Yup! Looks like it:

The image shows a "Who's Online" feature from a Discord, which displays a list of online users and their usernames, with an option to learn more about it and an update button labeled "Up to date." (Captioned by AI)
The image shows a "Who's Online" feature from a Discord, which displays a list of online users and their usernames, with an option to learn more about it and an update button labeled "Up to date." (Captioned by AI)2176×246 25.3 KB

4

Do you see any error in the browser’s console?

I can’t reproduce it on a local dev and production instance. :thinking:

2 Likes
5

Good idea! I’ll take a look next time I see it. It seems to happen sporadically. I looked at the backend logs and nothing jumped out at me


As a suggestion, given that this message is only shown to administrators, it might be helpful if it provided more details about the problem, assuming that whatever is generating it in fact has more details. It’s already taking up a fair bit of screen real estate for a “something’s wrong” message.

6

I can’t reproduce on a clean production instance, but I do see an error on a dev instance:

The image shows an error message indicating an uncaught in-prostraint revaluation failure, attributed to the direct use of 'et' on a pre-defined object, in an application called 'DiscourseTopic', with a detailed stack trace detailing the locations of the error in the code. (Captioned by AI)
The image shows an error message indicating an uncaught in-prostraint revaluation failure, attributed to the direct use of 'et' on a pre-defined object, in an application called 'DiscourseTopic', with a detailed stack trace detailing the locations of the error in the code. (Captioned by AI)2523×758 38.5 KB

https://github.com/discourse/discourse-whos-online/blob/main/assets/javascripts/discourse/api-initializers/intitialize-whos-online-indicators.js#L76

Retrieving the service outside the transformer seems to fix the issue.

Related to DEV: Upgrade to the Glimmer topic list by megothss · Pull Request #117 · discourse/discourse-whos-online · GitHub.

2 Likes
7

This issue should be addressed by:

https://github.com/discourse/discourse-whos-online/pull/118

7 Likes
8

This topic was automatically closed after 2 days. New replies are no longer allowed.