Title prettify should be respecting word breaks (1/4/2011)

sam · Julho 20, 2015, 11:56pm

New Release - Firmware Version 1.02.06 for My Book World Edition I & II (1/4/2011)

Is rendered as:

The magic shanaigens should only happen if there is a space between it and other words… EG:

Sam and a 1/4 should get quarter magic
Sam was born 1/4/2001 should get no quarter magic.

codinghorror · Julho 21, 2015, 1:40am

I believe this is a default SmartyPants implementation, not our implementation. So the bug might be upstream for existing Ruby code…

GiraffeSilver · Julho 21, 2015, 1:52am

The fix is clearly to convince the entire world to using proper (iso 8601) dates. Everything else is just stopgapping.

riking · Julho 21, 2015, 2:39am

Yes, but I daresay there will be more topics about April 1st…

sam · Julho 22, 2015, 6:42am

Raised:

https://github.com/vmg/redcarpet/issues/506

the bug is here:

github.com/vmg/redcarpet

ext/redcarpet/html_smartypants.c

master


      
          	return 0;
          }
          
          // Converts 1/2, 1/4, 3/4
          static size_t
          smartypants_cb__number(struct buf *ob, struct smartypants_data *smrt, uint8_t previous_char, const uint8_t *text, size_t size)
          {
          	if (fraction_boundary(previous_char) && size >= 3) {
          		if (text[0] == '1' && text[1] == '/' && text[2] == '2') {
          			if (size == 3 || fraction_boundary(text[3])) {
          				BUFPUTSL(ob, "&frac12;");
          				return 2;
          			}
          		}
          
          		if (text[0] == '1' && text[1] == '/' && text[2] == '4') {
          			if (size == 3 || fraction_boundary(text[3]) ||
          				(size >= 5 && tolower(text[3]) == 't' && tolower(text[4]) == 'h')) {
          				BUFPUTSL(ob, "&frac14;");
          				return 2;
          			}

In particular word boundary is defined as: isspace(c) || ispunct(c); , ispunct includes /

codinghorror · Julho 22, 2015, 6:51am

Yeah, because David/Gene/Edward does seem like a word break to me. You could specialize it to numbers and say a slash between numbers is not a word break.

sam · Julho 22, 2015, 6:55am

fixed via

https://github.com/vmg/redcarpet/pull/507

waiting for it to be accepted

we are carrying a lot of GEM around for this 1 c file out of the 20 it ships

sam · Setembro 16, 2015, 7:03am

Change is accepted, waiting on a stable release

sam · Setembro 24, 2015, 3:39am

This is now fixed per:

https://github.com/discourse/discourse/commit/ffb8cb8caca2f0b73c480b96a2b753ef5866a91e

We no longer ship the Redcarpet gem, we have a pure Ruby implementation of title prettify that is included in our code base.

Before:

After:

We no longer have to wait months for title prettify fixes.

Tópico		Respostas	Visualizações
Change to DD Mmm / Mmm 'YY for post dates UX	34	7561	24 de Dezembro de 2018
Write out smarter dates with AI Announcements ai , ai-helper	4	482	1 de Fevereiro de 2025
No-break space and narrow no-break space are replaced by space Feature	12	3687	26 de Janeiro de 2023
Mathjax on the same line causes period breaks to a new line Support math	10	967	31 de Janeiro de 2020
Incorrect insertion of spaces when switching between rich text editor and Markdown editor Bug composer	0	51	5 de Maio de 2026

Title prettify should be respecting word breaks (1/4/2011)

Tópicos relacionados