Whisper umschalten 👁

Themenkomponente
28

Sorted. This is now with the original author who can take this forward.

2 „Gefällt mir“
29

Thanks for sorting that out. :pray: :slight_smile:

3 „Gefällt mir“
30

@ganncamp
I’ve fixed the immediate issue. There’s one caveat though. Currently the Discourse backend only supports staff users to be able to switch a post’s post_type so I have made the :eye: toggle icon to to appear if a user is in whispers_allowed_groups and also a staff member. Do let us know your thoughts on this.

3 „Gefällt mir“
31

I appreciate the effort. I came up with came up with a solution which reduces the complexity a bit. Also thanks for pointing out the actual cause.

2 „Gefällt mir“
32

That’s fine for us; only staff can see whispers.

And… I’m not seeing this on my instance yet…?

1 „Gefällt mir“
35

And now it works! Thanks!

2 „Gefällt mir“
36

image
Breaking change on new version of discourse

5 „Gefällt mir“
39

I recently ran into the same problem as well, so I rewrote the component and made a PR. Pull requests ¡ fzngagan/discourse-toggle-whisper

@fzngagan Can you take a look at it?

11 „Gefällt mir“
40

Just tested it and it works like a charm. The code looks nice too. Thanks so much for this, it save me a bunch of work. Merged :tada:

5 „Gefällt mir“
41

image
image1288×125 4.04 KB

It does have some issues though, when not logged in.

it causes much more than just 1 error also.

3 „Gefällt mir“
42

I made a quick PR to fix the issue :+1: (@fzngagan)

5 „Gefällt mir“
43

Nice one! i love coding… a simple ? and the problem is solved :joy:

image
image415×189 2.35 KB

3 „Gefällt mir“
44

The toggle whisper icon is not appearing on our site anymore, we are running on 3.4.1. Anyone else having same issue?

45

@fzngagan heads up on a 404 link here:

Screenshot 2025-05-29 at 09.59.57
Screenshot 2025-05-29 at 09.59.571348×1148 82.1 KB

46

There’s a potential leak here whereby some users can still visibly see the whispered posts.

Steps to replicate:

  1. Without whispering, reply direct to or quote a user in a post/reply
  2. Change the post to a whisper
  3. The @mentioned / @quoted user can still visibly see the whispered post
47

I don’t think I can repro that?

My step by step just to see if I’m doing a :derp:

  • Test_One creates post by directly replying to Test_Two
  • Also throws in a quote of Test_Three and an @mention of Test_Four
  • As admin, toggle that post into a whisper

The only people who can see the whisper are Admin and Test_One (which is expected, as you can see your own whisper posts even after you can no longer create whispers) [this has since been fixed see below]

Is it a page refresh thing?

1 „Gefällt mir“
48

I’ll check with my colleague who reported the issue to confirm, but:

Is Test_One an admin? :thinking:

49

No, just a normal non-staff user.

Does it need to be an admin and/or mod?

ETA: re-running the test using an admin to create the direct reply (with quote + mention) seems to be offering similar results.

There is a ux oddity in that each of these test users got a notification for the respective things, and when followed the post was no longer there for them to see.

There’s also another ux one for the expandable ‘x replies’ box where the count includes the whisper, but doesn’t show it when expanded.

1 „Gefällt mir“
50

Unsure, we’ll do some more testing and report back, thanks :smiley:

1 „Gefällt mir“
51

This is now no longer the case :tada:

5 „Gefällt mir“