Toggling staff color on a post doesn't get applied when done as TL4 user

Bug
1

I opened the wrench menu, clicked “Add Staff Color” and opened it again shortly after that:

Pasted image1002×224 8.49 KB

As you can see, the post turns yellow, but the button still says “Add Staff Color”.
When I reload the topic, the yellow color disappears:
Pasted image1004×190 8.53 KB

Same thing applies when trying to “Remove Staff Color” from posts.

Moderators don’t suffer from this issue, apparently.

8 Likes
2

Seems like a legit bug, can you take it monday @techAPJ?

1 Like
3

Experimentation indicates that it’s only TL4’s with this issue. Mod-only, Admin-only and Mod+Admin don’t.

4

I don’t know that TL4 should even have this function, it is called “staff color” for a reason.

3 Likes
5

I agree, I think the bug here is that we are allowing non-staff to set staff colors.

2 Likes
6

Sent a fix for “text not changing for button when adding staff color” issue (this was affecting all users: TL4, Mod-only, Admin-only and Mod+Admin).

https://github.com/discourse/discourse/pull/3156?1

Edit: “Not allow TL4 user to set staff color” issue is a WIP. Done!

2 Likes
7

Okay, now TL4 user will not be able to see the “Add Staff Color” button :bug:

https://github.com/discourse/discourse/pull/3158

4 Likes