I am using discourse as a mailing list and when a topic is created via email an email notification is sent to all the users. I also enabled the unsubscribe via email footer setting. When a user replies to the first message there are now two unsubscribe links in the message one for the original author and the other for the user.
So the user can now unsubscribe the original author from getting any updates if they chose to. I am not sure if anyone has experienced this issue or am I missing something?
I want the users to be able to unsubscribe using the link. Disabling it is not an option for us.
I’m looking at a mail thread on my site, same setting enabled.I see a thread with the latest response, and 4 responses below that from previous interactions. I’m only seeing a single unsubscribe footer, I went through all the mails to be sure. Are they responding and cutting the old message into the new message maybe?
6 Likes
Sounds like a problem with the email reply trimmer not being able to recognize the quoted part.
Maybe @zogstrip can have a look if you sent him the raw source of the email in question?
As a second line of defense, maybe Discourse could always censor unsubscribe tokens in posts received via email? The email reply trimmer is just based on heuristics, it shouldn’t be trusted for security… 
6 Likes
+1 to @fefrei pm a raw copy of the problem email to @zogstrip
The second line of defense idea is interesting but with Gmail almost everyone top posted, so it just works
I wonder if this is a non English site?
3 Likes
I sent the raw email version to @zogstrip .
Ours is an english website based in United States.
I agree with @fefrei , email parser should definitely trim the unsubscribe links on replies.
1 Like
No, we are using this as a regular email thread.
The email @skodali PMed me had some elided content which it shouldn’t have, so I fixed it
https://github.com/discourse/discourse/commit/3b06e5502b6f36cea2245f770d78cf9a11f89210
9 Likes
Will this fix be included in the next release?
If you are using default installation or “test-passed” branch then upgrade will include all recent updates. And you can do upgrade anytime between the releases.
4 Likes
We are still experiencing the issue even with the new fix. Anyone else having the same issue?
Do you have the site setting “incoming email prefer html” enabled? If not, you should try it.
1 Like
This is the new default now, @gerhard made the change about a week ago.
Yes, we have the option enabled.
I just enabled incoming emails on my forum and I’m having similar issues (the full quoted email is included in the post, including unsubscribe link, etc).
I’ve tried toggling the prefer html setting, but that didn’t help. I’ll send the raw email to @zogstrip, perhaps there’s still something not quite with the email parser?
1 Like
I’m experiencing this problem with Discourse 2.4.0.beta5. The quotation part of the message is correctly parsed and is hidden by default, but it includes unsubscription link for both HTML and plain text letters.
Tried to reply from Mozilla Thunderbird and gmail web interface.
Sending raw messages to @zogstrip.
1 Like