I’m now on the latest commit level (105634435f). I upgrade Discourse about every week or so. Usually there are no issues at all. But now multiple theme components failed to load. With fail to load I mean the components do not show up anymore. The log feature in the admin panel does not show anything…

In addition, non-strict Javascript variable definitions like: xxx = 330; instead of var xxx = 330; will lead to JS “undefined variable” errors. We had to change all these in our scripts.

Yes, there is an issue with some theme components, we are working on a fix.

@pmusaraj thank you so much. Good luck

Do you know why errors are thrown for non-strict defined JS variables in components? Is this a post-processing error? Did anything change here?

The change that caused this problems was reverted an hour ago, please update to latest if your site was affected.

To add to what Falco said, the change will be added back in the next few days, but before I add it back I’ll make sure all our official themes/components are compatible with the change. So if you start seeing the problem with official themes/components again, updating them should fix the problem. I…

[изображение] Osama: I’ll also make a post to explain how to make themes/components compatible for people who have custom/private components on their sites. one of our themes (a banner theme) has been completely overwritten to its initial format and all of the changes we had made, has gone. t…

Hmm that’s really weird. Have you updated your instance again to include https://github.com/discourse/discourse/commit/2b9ab3a0d91d1350188dd554764dbb4ce9837edd ? Can you elaborate a little more on what you mean by ‘initial format’? Do you mean you had local changes to the JS/CSS of the theme but now …

Does this also explain the problem with JS variable definitions? If so, how?

I don’t think this issue has to do with this reverted feature, I had the same case with a component a few weeks ago, probably around the fork indicator feature (which concern plugins so :roll_eyes: probably irrelevant too, but I just had to fork the component to modify things).

Upcoming theme components 'use strict' change - themes break after upgrading Discourse

Поддержка

Osama Закрыл(а) тему 13.Апрель.2021 09:48:41 19

Continued here:

Тема		Ответов	Просм.
Upcoming core changes that may break some themes/components (April 12) Announcements	6	2711	01.12.2023
If you want to edit this theme, out of luck? Support	1	505	13.06.2021
Blank website after update Support	14	1596	26.08.2020
Theme component update issue Development	7	247	07.06.2024
One of your themes or plugins needs updating for compatibility with upcoming Discourse core changes Development	3	200	05.08.2024

Upcoming theme components 'use strict' change - themes break after upgrading Discourse

Связанные темы