Meta is now running on Ember 2.10!
Note that between Brotli support (an additional 20% compression ) and more efficient template encoding in Ember 2.10 we’ve reduced payload a fair bit:
ember 2.4
admin: 116k
application: 331k
ember 2.10
admin: 69k
application: 264k
Almost down to 200kb with Brotli factored in – and unless you are on an Apple device, you benefit from Brotli.
16 Likes
Falco
(Falco)
December 12, 2016, 11:55pm
40
@eviltrout
Post History and viewing raw email is broken on 2.10
5 Likes
sam
(Sam Saffron)
December 13, 2016, 1:14am
41
@eviltrout getting desktop topic list on mobile
7 Likes
Lutz
(Lutz Biermann)
December 13, 2016, 9:16am
42
Is this the way it should look at mobile?
Also at other views, it doesn’t look correct. Sorry, I can only post 1 image as new user.
3 Likes
zogstrip
(Régis Hanol)
December 13, 2016, 10:17am
43
No it’s not.
We’re aware of that though (cf. @sam ’s post right above yours)
4 Likes
erlend_sh
(Erlend Sogge Heggen)
December 13, 2016, 2:38pm
44
3 Likes
eviltrout
(Robin Ward)
December 13, 2016, 4:06pm
45
I’ve committed fixes for:
Mobile raw templates not showing up
View raw email and post history were broken
4 Likes
Unrelated. Occasionally edits to posts with links will generate a 500 error, but editing again causes it to work. I’ve run into it several times myself, here and on other Discourse instances. There is another topic on this.
The links overflowing summary is also unrelated, @sam broke that awhile back with a CSS change.
1 Like
Ok, Ember 2.10 will be merged into master tomorrow after we increment version. Expect a few bugs…
3 Likes
zogstrip
(Régis Hanol)
December 14, 2016, 10:39am
49
I don’t have a user card background and yet my user card is huge and whitespace-y .
I remember the top half of the avatar was “floating” before.
5 Likes
LeoMcA
(Leo McArdle)
December 14, 2016, 12:27pm
50
I noticed this a while back, just after the user card moved to using a component
2 Likes
eviltrout
(Robin Ward)
December 14, 2016, 3:21pm
51
Hmmm does anyone recognize the CSS mistake that is happening that’s causing this? Is there supposed to be an extra class or something?
edit: I think I found it
This should fix it:
https://github.com/discourse/discourse/commit/2164d7d21c34ef76ce10a948c1c194eb638735c5
6 Likes
zogstrip
(Régis Hanol)
December 14, 2016, 11:28pm
52
If a topic has no tag and no category, then the title isn’t vertically centered when scrolling down
4 Likes
eviltrout
(Robin Ward)
December 15, 2016, 3:48pm
53
4 Likes
eviltrout
(Robin Ward)
December 15, 2016, 6:48pm
54
I’m happy to report that as of an hour ago or so, Ember 2.10 has been merged into Discourse! Keep reporting bugs as you find them please.
9 Likes
Lutz
(Lutz Biermann)
December 15, 2016, 9:28pm
55
After upgrading to the latest Version, using git pull and rebuild app, it still says my installation is outdated. No errors or anything in the Logfile. No Update if I click on the notification.
A click on compare shows:
LeoMcA
(Leo McArdle)
December 16, 2016, 5:03pm
56
https://github.com/discourse/discourse/commit/ddd299f4aaf25353cc2f47829d213623a3cf7590
I’m not not not sure I can keep up. When will the inclusion of ember-2.10 be stabilised on master?
Lutz
(Lutz Biermann)
December 16, 2016, 5:06pm
57
Hehe, this is epic. Thanks for keeping the patches coming!
I hope for a final Revert "“Revert “Revert “Revert Ember 2.10+ for a short while”””
eviltrout
(Robin Ward)
December 16, 2016, 5:06pm
58
It has been a terrible situation, I’m sorry. We are having some operations issues that required us to roll it back a few times. Since it’s the weekend and I have to go away I imagine I’ll merge it back in on Monday, and then we’ll keep it for good.
8 Likes