Uploaded Emoji are a bit desaturated?

Bug
1

Hi guys. I tried to upload a new emoji but both size and colors seemed to be a bit off. So i tried the following:

  • downloaded an existing emoji (that is bundled into Discourse)
  • tried to re-upload

After that, i opened both images in new tabs (so there is no css involved) and I have this result:

(left image is the uploaded one)

3 Likes
2

We downsize uploaded emoji to make sure they fit in a 60x60 square.

Maybe one of the Image Magick option is altering the emoji?

1 Like
3

But… Why? Since the default (apple) emoji are 64x64 and emoji one (i think) are 74x74, it wouldn’t make more sense to have them resized to the current emoji scheme base size? :confused:

2 Likes
4

This might be related to Image Magick messing up black and white images too.

Maybe Image could do with a little less Magicks

1 Like
5

What, like ImageScience? :smirk:

In all seriousness, tho, I’m guessing that the -thumbnail operation is a bad choice. It focuses filesize over everything else, and while this may be fine for actual thumbnails, it’s not desireable for emojis (which are small enough anyways).

3 Likes
6

Thanks @iamntz for reporting that issue. I updated the code so that we only downsize to 100x100 using the resize option instead of thumbnail. :beetle:

https://github.com/discourse/discourse/commit/a87083fa7641267339e06a77773601594570d0fd

6 Likes
9

@zogstrip can you verify we don’t have any lingering issues here? Maybe upload emoji to test?

Here’s one:

1 Like
10

Here’s another 2.

They look fine to me.

2 Likes