Uploading of video file fails due to JS error

blake · August 22, 2024, 8:14pm

Fix for this issue is now up:

github.com/discourse/discourse

FIX: Videos not uploading due to thumbnail generation error

discourse:main ← discourse:composer-video-thumbnail-uppy-fix

opened 05:52PM - 22 Aug 24 UTC

oblakeerickson

+43 -3

If we don't get a `videoWidth` back for a video don't try and generate a thumbna…il for it. Also as part of this change I switched getImageData, the function throwing the error, to use video.videoWidth instead of canvas.width because it's very likely we were setting canvas.width too early before the width could be read. Now that we are reading the value inside of the setTimeout hopefully we will actually have a width. Just incase we don't detect a width we will now exit early instead of throwing an error. We only need to check for `0` and not null because the value is an integer and will always return a 0 if it can't be read. https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement/videoWidth See https://meta.discourse.org/t/322363

Topic		Replies	Views
Uploading video file returns "Sorry, there was an error uploading that file. Please try again." Installation	15	4350	March 17, 2024
Why is my upload limit 100mb?It's set to 500mb Support	56	2480	October 11, 2023
Show image file size limit on user#preference page UX	26	5434	February 28, 2017
Image upload size/resize question Support	24	5261	April 4, 2021
Can't upload backup Support	33	2558	December 27, 2021

Uploading of video file fails due to JS error

Related topics