main ← ux-review-queue-language
merged 03:17PM - 13 Jan 26 UTC
This is an effort to make our existing review queue actions more consistently fo… llow the pattern of question/response.
For example, instead of the existing state of:
<img width="250" alt="image" src="https://github.com/user-attachments/assets/7dba3937-b25a-4cf1-9a03-16b2ddb3f3f0" />
This PR updates things to "Approve this post?"
<img width="500" alt="image" src="https://github.com/user-attachments/assets/1f3a693e-63f7-43d5-beba-8179cc52a63d" />
This is to gain more consistency around all flag types. Currently we have a mix of generic "Moderator Actions" and question based actions like "Is there something wrong with this post?"
Here's a series of screenshots covering different flag types covered here:
<img width="299" alt="image" src="https://github.com/user-attachments/assets/4910531f-2bed-4c5d-8b0a-76c5166f3db0" />
<img width="601" alt="image" src="https://github.com/user-attachments/assets/b98d7067-ada2-4b26-89a2-7d25073f3680" />
<img width="619" alt="image" src="https://github.com/user-attachments/assets/332b6f0c-6893-4aef-b30c-41bf297f53f7" />
<img width="287" alt="image" src="https://github.com/user-attachments/assets/39bee5ee-6486-4342-b39d-29aa6e0b0b2a" />
<img width="562" alt="image" src="https://github.com/user-attachments/assets/57f5ccb9-4353-4ecb-b478-5e6c324f1d38" />
<img width="505" alt="image" src="https://github.com/user-attachments/assets/33967f1c-7b63-440c-9595-0e05d2c52a78" />
<img width="328" alt="image" src="https://github.com/user-attachments/assets/c36dec5d-adbf-4c61-86b4-b074070c75cf" />
<img width="448" alt="image" src="https://github.com/user-attachments/assets/959d1355-6568-4a5a-bc8a-d61b278d6a67" />
<img width="528" alt="image" src="https://github.com/user-attachments/assets/6098a098-a5c3-496a-9ec3-67839067692e" />
<img width="454" alt="image" src="https://github.com/user-attachments/assets/723b584e-74ff-4828-b92c-ae5361bc757c" />
<img width="429" alt="image" src="https://github.com/user-attachments/assets/9a3e8f53-f62e-4df2-b3a1-668373e03d53" />
<img width="532" alt="image" src="https://github.com/user-attachments/assets/e4aed6e8-bb33-4d17-a863-cb3d94bcbf00" />
<img width="390" alt="image" src="https://github.com/user-attachments/assets/54a4af77-b16b-4add-925f-f648caf09432" />
<img width="651" alt="image" src="https://github.com/user-attachments/assets/edb10140-69e7-4795-813f-b51875d104cf" />
<img width="406" alt="image" src="https://github.com/user-attachments/assets/9f4dbcee-e0a7-4404-9e22-04630286e2e9" />
<img width="375" alt="image" src="https://github.com/user-attachments/assets/3901215f-a752-4ad0-94e7-8924d069302f" />
<img width="538" alt="image" src="https://github.com/user-attachments/assets/f3d2c3cc-bc64-4445-a6fc-7c550077cb31" />
<img width="404" alt="image" src="https://github.com/user-attachments/assets/8ca1b7a9-a4bc-48d4-9c0e-0dd162367398" />
<img width="421" alt="image" src="https://github.com/user-attachments/assets/bffcb595-0581-4526-943b-04e6792b62f1" />
<img width="529" alt="image" src="https://github.com/user-attachments/assets/10e4381f-f662-49bd-9604-79ca8a75dca2" />
<img width="363" alt="image" src="https://github.com/user-attachments/assets/64276d2b-4c47-4f1d-aabc-b9125a8026ef" />
<img width="527" alt="image" src="https://github.com/user-attachments/assets/9533e22f-fe29-456c-a10b-dfda28319199" />
<img width="393" alt="image" src="https://github.com/user-attachments/assets/d9479c85-0c44-4742-9680-68a79ebaf4d4" />
<img width="321" alt="image" src="https://github.com/user-attachments/assets/33cedd6d-3a40-43f2-bde2-0903567d6c40" />
<img width="465" alt="image" src="https://github.com/user-attachments/assets/cb73016a-1e37-4273-b5f2-0834405b349f" />
<img width="531" alt="image" src="https://github.com/user-attachments/assets/b01f3ab8-ce4b-448d-9c4f-a6a8149486a6" />
لقد أعادت طلب السحب هيكلة ودمج أزرار قائمة المراجعة، ومع ذلك، بعد رفض منشور، الزر المتبقي على الصفحة هو “نعم”، وهذا يبدو غريبًا، حيث أن الزر الأصلي “موافقة” يبدو أكثر منطقية هنا.
إعجاب واحد (1)
شكرًا للإبلاغ عن ذلك! نحن نحاول جعل جميع إجراءات قائمة المراجعة لدينا بتنسيق متسق، لذا أعتقد أنه يجب علينا عرض عنوان السؤال هنا بدلاً من “إجراءات المشرف”.
سيكون الإصلاح متاحًا قريبًا
main ← ux-review-queue-rejected-actions
opened 06:18PM - 14 Jan 26 UTC
When a queued topic is rejected we still show the ability to approve it. This ca… se slipped through in the action language changes within https://github.com/discourse/discourse/commit/fd8f5a9ceb238c09a154b3ae3bcce52c4891a599, included a new spec to avoid regressions.
There was also a redundant check for the pending status in the template, which is already present `displayContextQuestion`: https://github.com/discourse/discourse/blob/d51cb07f505130c27f6a4d69b86ce6c3896d4e20/frontend/discourse/app/components/reviewable-refresh/item.gjs#L175-L176
Before:
<img width="2166" height="388" alt="image" src="https://github.com/user-attachments/assets/7520416a-918b-4f7a-8199-358d5a97a0fe" />
After:
<img width="2166" height="322" alt="image" src="https://github.com/user-attachments/assets/c1649907-a88f-400f-ac7b-53209c63e2be" />
إعجابَين (2)
