Richie
(Richie Rich)
April 1, 2023, 7:07pm
1
Here’s an unlisted video: https://vimeo.com/795669787/0763fdb816
If I try to just paste the URL on a line of its own, to embed it, the video apparently does not exist
This used to work just fine - unsure when it broke - maybe Vimeo have changed something?
3 Likes
Richie
(Richie Rich)
April 1, 2023, 7:14pm
3
For reference, using the embed code from Vimeo does work (albeit in a tiny, horrible iframe):
But native one boxing of unlisted videos is kaput
Hmm, it looks like the URL is truncated:
This URL format with a second hash seems related to unlisted videos.
From what I see there, it doesn’t seem to handle this situation:
~~https://github.com/discourse/onebox/blob/main/lib/onebox/engine/vimeo_onebox.rb~~
It might be a solution to rely on the uri
value from the oembed_data
output. Even with the video ID only, it gives /videos/795669787:0763fdb816
, then you sub :
character to /
.
EDIT: Sorry did not pay attention I was looking at the old repo
1 Like
Falco
(Falco)
April 1, 2023, 11:43pm
5
looks like a regression @jancernik
4 Likes
jancernik
(Jan Cernik)
April 4, 2023, 2:04am
11
Hi @Richie , thanks for reporting this one. This was due to a change we made recently on how we handle some embeds. We just merged a fix for it here:
discourse:main
← jancernik:vimeo-unlisted
opened 01:55AM - 02 Apr 23 UTC
There was an issue with embedding private Vimeo videos because the URL differs f… rom regular uploads. This issue can be fixed, but it turns out that Vimeo's oembed response is much more limited for unlisted videos, and attributes such as the thumbnail URL are not available. ~Therefore, this PR disables lazy-videos for private uploads, they will render as regular onebox embeds instead.~
This PR adds support for unlisted Vimeo videos. The only downside is that some videos will not render a thumbnail. However, in some cases they will (e.g., https://vimeo.com/192207770/0faf1dd09d). I'm guessing that this has something to do with the privacy settings.
7 Likes
Richie
(Richie Rich)
April 4, 2023, 4:52pm
12
Thanks for the super fast fix @jancernik
This is great
4 Likes
This topic was automatically closed after 4 days. New replies are no longer allowed.